Skip to content

fix: use @kikobeats/got to support Node.js 24.20 - #123

Merged
Kikobeats merged 1 commit into
masterfrom
Kikobeats/kikobeats-got-f8fa318b
Sep 17, 2026
Merged

Kikobeats merged 1 commit into
masterfrom
Kikobeats/kikobeats-got-f8fa318b

Conversation

@Kikobeats

@Kikobeats Kikobeats commented Sep 16, 2026 •

Copy link
Copy Markdown
Owner

got@11 is unmaintained and crashes on Node.js 24.20+ (nodejs/node#64847): a retried connection error rejects with ERR_SOCKET_CLOSED_BEFORE_CONNECTION and then throws uncaught exceptions, killing the process. @kikobeats/got is [email protected] with that fix backported (upstream declined a v11 release).

Here got downloads the Wappalyzer dataset in scripts/postinstall.js, so a flaky network during install is exactly the case that crashes on Node.js 24.20.

Changes

  • package.json: got ~11.8.6 → @kikobeats/got ~11.8.8
  • scripts/postinstall.js: require("got") → require("@kikobeats/got")

Testing

7 tests pass on Node.js 24.20.0 (CI lts/*) and 24.16.0, standard is clean, and the postinstall fetched the dataset through the new package (the regenerated src/*.json are left out of this PR).

🤖 Generated with Claude Code

https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC


Note

Low Risk
Drop-in replacement for the same got v11 API used only in postinstall fetch logic; no auth or runtime detection path changes.

Overview
Swaps the HTTP client from unmaintained got@11 to @kikobeats/got so npm install and the postinstall script can download Wappalyzer technology/category JSON on Node.js 24.20+ without process-killing uncaught exceptions on flaky retries.

package.json updates the dependency to ~11.8.8; scripts/postinstall.js points require at the fork. Behavior stays the same (same got@11 API), with the Node socket/retry fix backported.

Reviewed by Cursor Bugbot for commit 9f36eb7. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated the package dependency used during installation.
    • Preserved existing fetch and post-installation behavior.

got@11 is unmaintained and breaks on Node.js 24.20 (nodejs/node#64847):
a retried connection error rejects with ERR_SOCKET_CLOSED_BEFORE_CONNECTION
and then crashes the process with uncaught exceptions. @kikobeats/got is
got@11 with that fix backported.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC
@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1d3fa2fc-f37a-4b54-8eff-6be3c7e3da30

📥 Commits

Reviewing files that changed from the base of the PR and between 35b22b4 and 9f36eb7.

📒 Files selected for processing (2)
  • package.json
  • scripts/postinstall.js

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The pull request replaces the got dependency with @kikobeats/got and updates the postinstall script to require the scoped package. The version constraint changes from ~11.8.6 to ~11.8.8.

Changes

Scoped got dependency update

Layer / File(s) Summary
Dependency and postinstall import
package.json, scripts/postinstall.js
package.json declares @kikobeats/got at ~11.8.8. The postinstall script requires @kikobeats/got.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 9f36e

The scoped dependency preserves the postinstall API and does not introduce an identified installation or dataset-fetch failure.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: replacing the got dependency with @kikobeats/got to support Node.js 24.20.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Kikobeats/kikobeats-got-f8fa318b

Comment @coderabbitai help to get the list of available commands.

@Kikobeats
Kikobeats merged commit b7727a9 into master Sep 17, 2026
4 checks passed
@Kikobeats
Kikobeats deleted the Kikobeats/kikobeats-got-f8fa318b branch September 17, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant