Repository navigation
fix: use @kikobeats/got to support Node.js 24.20 - #123
Conversation
got@11 is unmaintained and breaks on Node.js 24.20 (nodejs/node#64847): a retried connection error rejects with ERR_SOCKET_CLOSED_BEFORE_CONNECTION and then crashes the process with uncaught exceptions. @kikobeats/got is got@11 with that fix backported. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe pull request replaces the ChangesScoped got dependency update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The scoped dependency preserves the postinstall API and does not introduce an identified installation or dataset-fetch failure. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
got@11is unmaintained and crashes on Node.js 24.20+ (nodejs/node#64847): a retried connection error rejects withERR_SOCKET_CLOSED_BEFORE_CONNECTIONand then throws uncaught exceptions, killing the process.@kikobeats/gotis[email protected]with that fix backported (upstream declined a v11 release).Here got downloads the Wappalyzer dataset in
scripts/postinstall.js, so a flaky network during install is exactly the case that crashes on Node.js 24.20.Changes
package.json:got ~11.8.6→@kikobeats/got ~11.8.8scripts/postinstall.js:require("got")→require("@kikobeats/got")Testing
7 tests pass on Node.js 24.20.0 (CI
lts/*) and 24.16.0,standardis clean, and the postinstall fetched the dataset through the new package (the regeneratedsrc/*.jsonare left out of this PR).🤖 Generated with Claude Code
https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC
Note
Low Risk
Drop-in replacement for the same got v11 API used only in postinstall fetch logic; no auth or runtime detection path changes.
Overview
Swaps the HTTP client from unmaintained
got@11to@kikobeats/gotsonpm installand thepostinstallscript can download Wappalyzer technology/category JSON on Node.js 24.20+ without process-killing uncaught exceptions on flaky retries.package.jsonupdates the dependency to~11.8.8;scripts/postinstall.jspointsrequireat the fork. Behavior stays the same (samegot@11API), with the Node socket/retry fix backported.Reviewed by Cursor Bugbot for commit 9f36eb7. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit