Fix interaction between GL_EXT_mesh_shader and GL_EXT_fragment_shading_rate#3298
Merged
arcady-lunarg merged 2 commits intoKhronosGroup:mainfrom Aug 7, 2023
zeux:extms-shadingrate-fix
Merged
Fix interaction between GL_EXT_mesh_shader and GL_EXT_fragment_shading_rate#3298arcady-lunarg merged 2 commits intoKhronosGroup:mainfrom zeux:extms-shadingrate-fix
arcady-lunarg merged 2 commits intoKhronosGroup:mainfrom
zeux:extms-shadingrate-fix
Conversation
…g_rate Before this change, using gl_MeshPrimitivesEXT in mesh shader would unconditionally create gl_MeshPrimitivesEXT.gl_PrimitiveShadingRateEXT field and add PrimitiveShadingRateKHR capability to the output SPIRV file, which would subsequently trigger validation errors when creating the shader module unless the application requested primitive shading rate feature. What should happen instead is that unless GL_EXT_fragment_shading_rate extension is enabled, we should not allow using gl_PrimitiveShadingRateEXT and should not emit the associated fields into the output. This change fixes this by using existing filterMember mechanism that is already used in a few other cases like this, and adjusting the required extension on the field member which will generate an error when gl_PrimitiveShadingRateEXT is used without enabling the extension.
|
|
arcady-lunarg
approved these changes
Aug 7, 2023
Contributor
arcady-lunarg
left a comment
arcady-lunarg
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, using gl_MeshPrimitivesEXT in mesh shader would unconditionally create gl_MeshPrimitivesEXT.gl_PrimitiveShadingRateEXT field and add PrimitiveShadingRateKHR capability to the output SPIRV file, which would subsequently trigger validation errors when creating the shader module unless the application requested primitive shading rate feature.
What should happen instead is that unless GL_EXT_fragment_shading_rate extension is enabled, we should not allow using
gl_PrimitiveShadingRateEXT and should not emit the associated fields into the output.
This change fixes this by using existing filterMember mechanism that is already used in a few other cases like this, and adjusting the required extension on the field member which will generate an error when gl_PrimitiveShadingRateEXT is used without enabling the extension.
Fixes #3103.