Tolerate throws in wasm/* tests, add 2gb-in-4gb variants.#3665
Merged
kdashg merged 2 commits intoKhronosGroup:mainfrom Jul 25, 2024
Merged
Tolerate throws in wasm/* tests, add 2gb-in-4gb variants.#3665kdashg merged 2 commits intoKhronosGroup:mainfrom
kdashg merged 2 commits intoKhronosGroup:mainfrom
Conversation
For browsers that don't support this large of wasm memory sizes, consider as PASS, so that browser features don't block webgl conformance. For UAs that throw on use of large TypedArrays, FAIL but safely. Also, Firefox *does* support ~4GB wasm memory sizes, but currently throws when >2GB TypedArray views are passed to entrypoints. However, Firefox does support <2GB-sized views of >2GB ArrayBuffers, so add tests for that. This reflects the ability for apps to use large WASM heaps, so long as only smaller views are passed to webgl.
Contributor
Author
|
Chrome Canary: All tests pass |
kenrussell
approved these changes
Jul 24, 2024
Member
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
Looks great, thanks for revising the tests. A few small requests about making all the test descriptions more similar; please feel free to merge yourself. Thanks.
sdk/tests/conformance2/wasm/bufferdata-2gb-in-4gb-wasm-memory.html
Outdated
Show resolved
Hide resolved
sdk/tests/conformance2/wasm/buffersubdata-2gb-in-4gb-wasm-memory.html
Outdated
Show resolved
Hide resolved
sdk/tests/conformance2/wasm/getbuffersubdata-2gb-in-4gb-wasm-memory.html
Outdated
Show resolved
Hide resolved
sdk/tests/conformance2/wasm/readpixels-2gb-in-4gb-wasm-memory.html
Outdated
Show resolved
Hide resolved
sdk/tests/conformance2/wasm/teximage2d-2gb-in-4gb-wasm-memory.html
Outdated
Show resolved
Hide resolved
sdk/tests/conformance2/wasm/texsubimage2d-2gb-in-4gb-wasm-memory.html
Outdated
Show resolved
Hide resolved
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For browsers that don't support this large of wasm memory sizes, consider as PASS, so that browser features don't block webgl conformance.
For UAs that throw on use of large TypedArrays, FAIL but safely.
Also, Firefox does support ~4GB wasm memory sizes, but currently throws when >2GB TypedArray views are passed to entrypoints. However, Firefox does support <2GB-sized views of >2GB ArrayBuffers, so add tests for that.
This reflects the ability for apps to use large WASM heaps, so long as only smaller views are passed to webgl.