Add WEBGL_multi_draw tests using SharedArrayBuffer.#3289
Merged
kenrussell merged 1 commit intoJun 10, 2021
Conversation
These are likely to require additional browser command-line arguments since otherwise this functionality requires special configuration of the web server hosting these tests. Regression test for KhronosGroup#3286. Associated with http://crbug.com/1211185 .
kenrussell
requested review from
kdashg and
shrekshao
and removed request for
kdashg
June 9, 2021 00:03
Member
Author
|
@shrekshao : please review. @jdashg , others: any comments welcome. |
Member
Author
|
Note that the duplication slightly increases the run time of this test, but even with this addition, it's still around 2.2 seconds on my work laptop. |
shrekshao
approved these changes
Jun 9, 2021
shrekshao
left a comment
shrekshao
left a comment
Member
There was a problem hiding this comment.
LGTM.
(The reason for only testing STATIC_DRAW with SharedArrayBuffer is?)
Member
Author
To reduce the overhead and duplication in the test. |
Member
Author
|
Thanks for your review @shrekshao . I'll wait until tomorrow to merge this in case Jeff has feedback. |
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Jun 9, 2021
Enables these APIs to be used from web workers and multithreaded WebAssembly applications. Tested with addition to the WebGL conformance suite: KhronosGroup/WebGL#3289 which will be rolled into Chromium shortly. Bug: 1211185 Change-Id: I5ee979f24d6255056005d1909c9e27a71b436ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2940137 Commit-Queue: Yuki Shiino <[email protected]> Auto-Submit: Kenneth Russell <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Reviewed-by: Shrek Shao <[email protected]> Cr-Commit-Position: refs/heads/master@{#890693}
Member
Author
|
Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are likely to require additional browser command-line arguments
since otherwise this functionality requires special configuration of
the web server hosting these tests.
Regression test for #3286.
Associated with http://crbug.com/1211185 .