Add [AllowShared] to WEBGL_multi_draw APIs' typed array arguments.#3286
Merged
kdashg merged 1 commit intoMay 18, 2021
Merged
Conversation
Parallels changes made in KhronosGroup#2387 to the core WebGL 1.0 and 2.0 specifications to support SharedArrayBuffer, and implicitly, multithreaded WebAssembly. Fixes KhronosGroup#3219 .
shrekshao
approved these changes
May 18, 2021
shrekshao
left a comment
shrekshao
left a comment
Member
There was a problem hiding this comment.
LGTM! thanks for the change
kdashg
approved these changes
May 18, 2021
|
Awesome, thank you @kenrussell & @shrekshao ! |
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Jun 9, 2021
These are likely to require additional browser command-line arguments since otherwise this functionality requires special configuration of the web server hosting these tests. Regression test for KhronosGroup#3286. Associated with http://crbug.com/1211185 .
kenrussell
added a commit
that referenced
this pull request
Jun 10, 2021
These are likely to require additional browser command-line arguments since otherwise this functionality requires special configuration of the web server hosting these tests. Regression test for #3286. Associated with http://crbug.com/1211185 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallels changes made in #2387 to the core WebGL 1.0 and 2.0
specifications to support SharedArrayBuffer, and implicitly,
multithreaded WebAssembly.
Fixes #3219 .