VK_EXT_scalar_block_layout (v2) - #567
Merged
Merged
Conversation
Bit flags that don't have any members (e.g. VkRenderPassCreateFlagBits) don't generate in the vulkan headers, but were generating for the enum string helper - causing compile errors. Added a check for such types with no flags to fix the error.
Added code to use scalar block layout validation in spirv-val when VK_EXT_scalar_block_layout is enabled. Added positive test for this, mirroring the relaxed block layout extension test.
mikes-lunarg
approved these changes
Jan 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #497