Author piofra01-arm not on autobuild list. Waiting for curator authorization before starting CI build.

All committers have signed the CLA.

CI Vulkan-ValidationLayers build queued with queue ID 28684.

CI Vulkan-ValidationLayers build # 10886 running.

CI Vulkan-ValidationLayers build # 10886 passed.

Minor issue with the formatting of the commit see https://github.com/KhronosGroup/Vulkan-ValidationLayers/actions/runs/4286113485/jobs/7465624547

I really want a test to prevent regression of this. Do you have a SPIR-V example that was hitting this, I am willing to add the test if you don't want to

Author piofra01-arm not on autobuild list. Waiting for curator authorization before starting CI build.

Author piofra01-arm not on autobuild list. Waiting for curator authorization before starting CI build.

Here are the shaders used in the test where the issue was spotted:

5349.vert.txt

5349.frag.txt

The test mostly just draws a quad, the only twist is that it uses data from the shared buffer in the fragment shader. It doesn't do anything special, besides setting up basic scaffolding to create the buffer and pass it to the vertex shader.

Specifically:

• The shared buffer is created with usage flags: VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT_KHR | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT and alloc flag: VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR.
• We instantiate some test data and upload it to the buffer.
• Then the shared buffer is referenced with a VkDeviceAddress, whose value is then stored in yet another buffer that is passed to the vertex shader.

The input description/state looks as follows:

	/* Vertex input descriptions */
	VkVertexInputBindingDescription binding_desc[2] = {};
	binding_desc[0].binding = 0;
	binding_desc[0].stride = sizeof(float) * 4;
	binding_desc[0].inputRate = VK_VERTEX_INPUT_RATE_VERTEX;
	binding_desc[1].binding = 1;
	binding_desc[1].stride = sizeof(VkDeviceAddress);
	binding_desc[1].inputRate = VK_VERTEX_INPUT_RATE_INSTANCE;

	/* Vertex input attribute descriptions */
	VkVertexInputAttributeDescription attributes[2] = {};
	attributes[0].location = 0;
	attributes[0].binding = binding_desc[0].binding;
	attributes[0].format = VK_FORMAT_R32G32B32A32_SFLOAT;
	attributes[0].offset = 0;
	attributes[1].location = 1;
	attributes[1].binding = binding_desc[1].binding;
	attributes[1].format = VK_FORMAT_R32G32_UINT;
	attributes[1].offset = 0;

	/* Vertex input state */
	VkPipelineVertexInputStateCreateInfo pipe_vert_state_create_info = {};
	pipe_vert_state_create_info.sType = VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO;
	pipe_vert_state_create_info.pNext = nullptr;
	pipe_vert_state_create_info.vertexBindingDescriptionCount = 2;
	pipe_vert_state_create_info.pVertexBindingDescriptions = binding_desc;
	pipe_vert_state_create_info.vertexAttributeDescriptionCount = 2;
	pipe_vert_state_create_info.pVertexAttributeDescriptions = attributes;

Author piofra01-arm not on autobuild list. Waiting for curator authorization before starting CI build.

@piofra01-arm thanks for the descriptive example. I am going to quick write up a negative test to

1. Prevent future regressions
2. Make sure this is the actual correct fix and that there isn't something more subtle that needs to be fixed

CI Vulkan-ValidationLayers build queued with queue ID 31975.

CI Vulkan-ValidationLayers build # 10967 running.

CI Vulkan-ValidationLayers build # 10967 passed.