Fix false positive error: push descriptor not set#433
Merged
jzulauf-lunarg merged 1 commit intomasterfrom Nov 6, 2018
Merged
Conversation
jzulauf-lunarg
requested review from
daveh-lunarg,
mark-lunarg,
mikes-lunarg,
shannon-lunarg and
tobine
jzulauf-lunarg
changed the title
|
Thanks! |
Contributor
Author
|
This is a quick easy review... |
tobine
approved these changes
Nov 6, 2018
Contributor
tobine
left a comment
tobine
left a comment
There was a problem hiding this comment.
LGTM. Incomplete comment.
layers/core_validation.cpp
Outdated
| // TODO -- remove this continue path when CmdPushDescriptorSet is implemented, for now it prevents a false positive | ||
| if ((setIndex < pipeline_layout.set_layouts.size()) && pipeline_layout.set_layouts[setIndex] && | ||
| pipeline_layout.set_layouts[setIndex]->IsPushDescriptor()) { | ||
| // Push descriptors currently don't |
Contributor
There was a problem hiding this comment.
seems like this comment is incomplete
Prevent false positive regarding push descriptors that have been set, not being set. This fix avoids the false positive but adds no additional push descriptor validation. Change-Id: I9a75db913927742a1f39e92fbdb177a3ce081117
jzulauf-lunarg
force-pushed
the
zulauf_pd_false_positive_341
branch
from
4b293ae to
c1a55a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent false positive regarding push descriptors that have been set,
not being set.
This fix avoids the false positive but adds no additional push
descriptor validation.
Fixes #341 -- tested against the given CTS testcase.