Skip to content

headers: Update to Vulkan header version 1.1.93 - #31

Closed
Tobski wants to merge 1 commit into
masterfrom
tobias-93-header-update
Closed

headers: Update to Vulkan header version 1.1.93#31
Tobski wants to merge 1 commit into
masterfrom
tobias-93-header-update

Conversation

@Tobski

@Tobski Tobski commented Nov 21, 2018

Copy link
Copy Markdown

Needed for validation work for EXT_scalar_block_layout - hopefully I've done this right...?

@CLAassistant

CLAassistant commented Nov 21, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@shannon-lunarg shannon-lunarg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the start of something good. For these changes did you follow the steps outlined in the Vulkan-Headers wiki to perform the header update? This PR reveals the importance for me to review and/or update the wiki page to reflect the current header update practices (what's there now is probably good enough but I need to add a couple more items for thoroughness). Then if the usual Headers Updater (me at the moment) is AFK someone else can perform the update if necessary.

Because the 1.1.94 Vulkan header was released between now and when you created this PR I am working on the 1.1.94 header update (branch name shannon-94-header-update) and will have a PR up shortly.

@Tobski

Tobski commented Nov 28, 2018

Copy link
Copy Markdown
Author

@shannon-lunarg I think I actually missed the valid usage json file now I look over the wiki again - figuring out how to build vulkan-hpp correctly took too many cycles I guess! Anyway, if you're updating now, I'll close this :)

@Tobski Tobski closed this Nov 28, 2018
@Tobski
Tobski deleted the tobias-93-header-update branch November 28, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants