-
Notifications
You must be signed in to change notification settings - Fork 649
spirv-fuzz: Report fresh ids in transformations #3856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vasniktel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've left a question about NullOverflowIdSource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I did not check every test nor every transformation, but I think I have checked pretty much everything else.
google/googletest@548b13d...1336c4b $ git log 548b13dc3..1336c4b6d --date=short --no-merges --format='%ad %ae %s' 2022-09-13 dmauro Fix MSVC C++14 flag for GitHub workflow 2022-09-13 dmauro Rollback 4fa8cfe3f4dee8975ee02d98633a5245ab67c6d7 2022-09-09 absl-team Use UnorderedElementsAre in example about using matchers with maps 2022-09-08 absl-team Remove obsolete MSVC warning pragmas for Invalid<T>() 2022-09-01 absl-team Fixed header guards to match style guide conventions. 2022-08-26 absl-team Consider all TERM values ending in "-256color" to be color supporting. In particular this handles TERM=hterm-256color correctly. 2022-08-22 hardikv Add support of 19-member structs to gmock UnpackStructImpl. 2022-08-19 keithbsmiley bazel: move -std=c++14 to .bazelrc 2022-08-16 dmauro Update README.md to point to the Foundational C++ Support Policy 2022-08-12 dmauro Add --features=external_include_paths to Bazel CI to ignore warnings from dependencies 2022-08-08 dinor gtest_unittest: Call FAIL() in lambda, fix incorrect fatality expectation 2022-08-04 dinor Explicitly instantiate matchee std::string in MatchesRegex 2022-07-28 absl-team Add support of 18-member structs to gmock UnpackStructImpl. 2022-07-25 dinor Add IsEmpty overload for C-style strings 2022-07-21 thegeorg Continuation for KhronosGroup#3183 2022-07-20 matdibu gtest-death-test: add 'noreturn' 2022-06-28 dev Set cmake policy CMP0069 2022-07-14 polushin export ThreadLocalValueHolderBase which is required by exported APIs. 2022-07-11 polushin cmake: make PDB output directory match that of a static library. 2022-07-11 polushin cmake: find python in order specified by PATH environment variable. 2022-07-11 dmauro Add envvar BAZEL_CXXOPTS=-std=c++14 to the GitHub Actions CI 2022-07-08 dmauro CMake: raise the default C++ standard to cxx_std_14 2022-07-07 ckennelly Enable heterogeneous lookup for RegisteredTestsMap. 2022-07-01 nikiforov.al cleanup from unique_ptr branch 2022-07-01 dmauro Remove the Bazel provided default cxxopt -std=c++0x and replace it with -std=c++14 when testing with GCC 5. 2022-07-01 57719497+yutotnh fix: some typos in source 2022-07-01 57719497+yutotnh fix: typo in test name 2022-07-01 57719497+yutotnh fix: some typos in comment 2022-06-30 dmauro Remove support for C++11 2022-06-30 dmauro Update version number in CMakeLists.txt Note that this is 1.12.1 as there will be a patch release to fix this 2022-06-29 absl-team Add support of 17-member structs to gmock UnpackStructImpl. 2022-06-27 absl-team Mark internal-only function as having internal linkage. 2022-06-27 93249401+assafpr Update gtest.cc 2022-06-27 93249401+assafpr Update gmock-matchers.h 2022-06-27 93249401+assafpr Update gmock-actions.h 2022-06-27 93249401+assafpr Update gmock-spec-builders_test.cc 2022-06-27 93249401+assafpr Update gtest-death-test.cc 2022-06-27 93249401+assafpr Update gmock-spec-builders.cc 2022-06-27 93249401+assafpr Update advanced.md 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-25 julian.arkenau docs: update googletest README for release 1.12.0 2022-06-23 dmauro Update README.md for release 1.12.0 2022-06-22 dmauro Update versions of WORKSPACE dependencies 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update faq.md 2022-06-22 93249401+assafpr Update CONTRIBUTING.md 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update gmock_output_test_golden.txt 2022-06-22 93249401+assafpr change link from master to main in documentation 2022-06-21 dmauro Update GCC floor container used by CI to fix the Bazel cache error 2022-06-16 dmauro Disable warning C4251 around refactored code 2022-06-13 absl-team gmock_cook_book.md: Delete superfluous statement from 2014. 2022-06-11 gpetit Move declaration of kStdOutFileNo and kStdErrFileno 2022-06-09 absl-team Update googletest docs to indicate that RE2 is now used for regexp implementation when building with Bazel and using Abseil. 2022-06-09 absl-team Remove undefined internal function. Fixes KhronosGroup#3856 2022-06-01 dmauro Work around a maybe-uninitialized warning under GCC 12 2022-05-31 gpetit Fix for undefined symbol: testing::internal::Random::kMaxRange 2022-05-30 gpetit Simplify ColoredPrintf to rely on ShouldUseColor 2022-05-30 gpetit Fix "unused variable" warning 2022-05-18 akohlmey set -utf-8 flag only for real MSVC compilers. E.g. not Intel's icx.exe 2022-03-26 perez.cs Fix quickstart-cmake documentation Created with: roll-dep external/googletest
google/googletest@548b13d...d9bb841 $ git log 548b13dc3..d9bb8412d --date=short --no-merges --format='%ad %ae %s' 2022-10-07 ferenc.gm Suggests a release with fixed CMakeLists.txt 2022-10-07 absl-team Update the POSIX Extended section of the Regular Expression Wikipedia page 2022-10-06 absl-team [fuchsia] Use __builtin_trap to trigger gunit_break_on_failure on non-x86 arch 2022-10-05 absl-team Makes Clang compilations via Ninja on Windows define _DLL only for shared CRT builds, as one would already expect from MSVC builds. (Previously, static Clang/Ninja builds on Windows also implicitly defined _DLL, which was problematic.) 2022-09-30 absl-team Uses a simpler mechanism to disable the copying of GoogleTest test suites, to move code out of the TEST_P macro. 2022-09-28 absl-team Rollback: Moves boilerplate disabling copy constructor/assignment from GoogleTest's TEST_P macro into a header file to avoid triggering warnings in user code. 2022-09-28 absl-team Rollback: Uses a simpler mechanism to disable the copying of GoogleTest test suites. 2022-09-28 absl-team Uses a simpler mechanism to disable the copying of GoogleTest test suites. 2022-09-28 absl-team Moves boilerplate disabling copy constructor/assignment from GoogleTest's TEST_P macro into a header file to avoid triggering warnings in user code. 2022-09-27 absl-team Add GoogleTest workaround for MSVC crash with Address Sanitizer (ASAN) on version 17.3.3 2022-09-27 cclauss Branding: macOS 2022-09-27 cclauss Upgrade GitHub Actions Checkout 2022-09-20 maratek Port GoogleTest to QuRT (Hexagon RTOS) 2022-09-18 426690+softwaregravy Update link to Bazel installation guide 2022-09-13 dmauro Fix MSVC C++14 flag for GitHub workflow 2022-09-13 dmauro Rollback 4fa8cfe3f4dee8975ee02d98633a5245ab67c6d7 2022-09-09 absl-team Use UnorderedElementsAre in example about using matchers with maps 2022-09-08 absl-team Remove obsolete MSVC warning pragmas for Invalid<T>() 2022-09-01 absl-team Fixed header guards to match style guide conventions. 2022-08-26 absl-team Consider all TERM values ending in "-256color" to be color supporting. In particular this handles TERM=hterm-256color correctly. 2022-08-22 hardikv Add support of 19-member structs to gmock UnpackStructImpl. 2022-08-19 keithbsmiley bazel: move -std=c++14 to .bazelrc 2022-08-16 dmauro Update README.md to point to the Foundational C++ Support Policy 2022-08-12 dmauro Add --features=external_include_paths to Bazel CI to ignore warnings from dependencies 2022-08-08 dinor gtest_unittest: Call FAIL() in lambda, fix incorrect fatality expectation 2022-08-04 dinor Explicitly instantiate matchee std::string in MatchesRegex 2022-07-31 bmburstein Custom type with Combine(). Fix for #3781 2022-07-28 absl-team Add support of 18-member structs to gmock UnpackStructImpl. 2022-07-25 dinor Add IsEmpty overload for C-style strings 2022-07-21 thegeorg Continuation for #3183 2022-07-20 matdibu gtest-death-test: add 'noreturn' 2022-06-28 dev Set cmake policy CMP0069 2022-07-14 polushin export ThreadLocalValueHolderBase which is required by exported APIs. 2022-07-11 polushin cmake: make PDB output directory match that of a static library. 2022-07-11 polushin cmake: find python in order specified by PATH environment variable. 2022-07-11 dmauro Add envvar BAZEL_CXXOPTS=-std=c++14 to the GitHub Actions CI 2022-07-08 dmauro CMake: raise the default C++ standard to cxx_std_14 2022-07-07 ckennelly Enable heterogeneous lookup for RegisteredTestsMap. 2022-07-01 nikiforov.al cleanup from unique_ptr branch 2022-07-01 dmauro Remove the Bazel provided default cxxopt -std=c++0x and replace it with -std=c++14 when testing with GCC 5. 2022-07-01 57719497+yutotnh fix: some typos in source 2022-07-01 57719497+yutotnh fix: typo in test name 2022-07-01 57719497+yutotnh fix: some typos in comment 2022-06-30 dmauro Remove support for C++11 2022-06-30 dmauro Update version number in CMakeLists.txt Note that this is 1.12.1 as there will be a patch release to fix this 2022-06-29 absl-team Add support of 17-member structs to gmock UnpackStructImpl. 2022-06-27 absl-team Mark internal-only function as having internal linkage. 2022-06-27 93249401+assafpr Update gtest.cc 2022-06-27 93249401+assafpr Update gmock-matchers.h 2022-06-27 93249401+assafpr Update gmock-actions.h 2022-06-27 93249401+assafpr Update gmock-spec-builders_test.cc 2022-06-27 93249401+assafpr Update gtest-death-test.cc 2022-06-27 93249401+assafpr Update gmock-spec-builders.cc 2022-06-27 93249401+assafpr Update advanced.md 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-25 julian.arkenau docs: update googletest README for release 1.12.0 2022-06-23 dmauro Update README.md for release 1.12.0 2022-06-22 dmauro Update versions of WORKSPACE dependencies 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update faq.md 2022-06-22 93249401+assafpr Update CONTRIBUTING.md 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update gmock_output_test_golden.txt 2022-06-22 93249401+assafpr change link from master to main in documentation 2022-06-21 dmauro Update GCC floor container used by CI to fix the Bazel cache error 2022-06-16 dmauro Disable warning C4251 around refactored code 2022-06-13 absl-team gmock_cook_book.md: Delete superfluous statement from 2014. 2022-06-11 gpetit Move declaration of kStdOutFileNo and kStdErrFileno 2022-06-09 absl-team Update googletest docs to indicate that RE2 is now used for regexp implementation when building with Bazel and using Abseil. 2022-06-09 absl-team Remove undefined internal function. Fixes #3856 2022-06-01 dmauro Work around a maybe-uninitialized warning under GCC 12 2022-05-31 gpetit Fix for undefined symbol: testing::internal::Random::kMaxRange 2022-05-30 gpetit Simplify ColoredPrintf to rely on ShouldUseColor 2022-05-30 gpetit Fix "unused variable" warning 2022-05-18 akohlmey set -utf-8 flag only for real MSVC compilers. E.g. not Intel's icx.exe 2022-03-26 perez.cs Fix quickstart-cmake documentation Created with: roll-dep external/googletest
Adds a virtual method, GetFreshIds(), to Transformation. Every
transformation uses this to indicate which ids in its protobuf message
are fresh ids. This means that when replaying a sequence of
transformations the replayer can obtain a smallest id that is not in
use by the module already and that will not be used by any
transformation by necessity. Ids greater than or equal to this id
can be used as overflow ids.
Fixes #3851.