-
Notifications
You must be signed in to change notification settings - Fork 649
Add data structures for DebugScope, DebugNoScope, DebugDeclare, DebugValue #3183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5079d94 to
36e61b9
Compare
s-perron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this done. It think it is still incomplete.
jaebaek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your detailed feedback.
I mostly updated the code based on your comments except local_var_info_.
I want to keep a map between local variables (result ids of OpVariable or OpFunctionParameter) to DebugDeclare (or DebugValue).
Since DebugDeclare provides the information that a DebugLocalVariable is mapped to a local variable OpVariable, I believe it must follow OpVariable.
I want to emit it right after OpVariable. See my comment.
|
Because of a test failure, I rebased it with the upstream master |
s-perron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a problem with the handling of OpDebugValue. See my comments in the review.
jaebaek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mainly added debug_insts_in_header_ in Function class to keep DebugDeclare/DebugValue instructions in a function but outside a basic block. PTAL
s-perron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good. Sorry I keep bringing up new things that I should have seen earlier.
jaebaek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for comments. I updated it based on the feedback. PTAL!
|
Rebased |
When ir_loader processes DebugScope/DebugNoScope, we update |last_dbg_scope_| of ir_loader to update the last DebugScope information. When ir_loader processes a terminator instruction or merge instruction, it sets |last_dbg_scope_| as DebugNoScope because it is the end of the scope. When module dumps IR, if the next DebugScope is new scope information, it generates a DebugScope instruction. If the next DebugScope denotes the end of a scope, it generates a DebugNoScope instruction.
We put only `DebugDeclare` instructions in `local_var_to_dbg_decl_` but we change the name of the map to `local_var_info_` and we put `DebugValue` in it as well. Before this change, we put `DebugValue` in `InstructionList` of `BasicBlock` like a normal instruction, but it worries me that `DebugValue` between `OpVariable` instructions can cause bugs. For example, `InlinePass::CloneAndMapLocals()` iterates first instructions of function body while their opcode is `OpVariable`. The assumption behind this is that `OpVariable` instructions can be placed only in the header of a function body. If an instruction other than `OpVariable` is shown, `OpVariable` instruction will not be shown anymore. However, this assumption is false when we add `DebugValue` between `OpVariable` instructions, which results in wrong optimization.
We do not keep stand-alone OpLine instructions in a basicblock. OpLine is only accessed by its corresponding Instruction. We should consider OpLine is just a part of its Instruction. Therefore, we want to use the same DebugScope information of an Instruction for its OpLine.
google/googletest@548b13d...1336c4b $ git log 548b13dc3..1336c4b6d --date=short --no-merges --format='%ad %ae %s' 2022-09-13 dmauro Fix MSVC C++14 flag for GitHub workflow 2022-09-13 dmauro Rollback 4fa8cfe3f4dee8975ee02d98633a5245ab67c6d7 2022-09-09 absl-team Use UnorderedElementsAre in example about using matchers with maps 2022-09-08 absl-team Remove obsolete MSVC warning pragmas for Invalid<T>() 2022-09-01 absl-team Fixed header guards to match style guide conventions. 2022-08-26 absl-team Consider all TERM values ending in "-256color" to be color supporting. In particular this handles TERM=hterm-256color correctly. 2022-08-22 hardikv Add support of 19-member structs to gmock UnpackStructImpl. 2022-08-19 keithbsmiley bazel: move -std=c++14 to .bazelrc 2022-08-16 dmauro Update README.md to point to the Foundational C++ Support Policy 2022-08-12 dmauro Add --features=external_include_paths to Bazel CI to ignore warnings from dependencies 2022-08-08 dinor gtest_unittest: Call FAIL() in lambda, fix incorrect fatality expectation 2022-08-04 dinor Explicitly instantiate matchee std::string in MatchesRegex 2022-07-28 absl-team Add support of 18-member structs to gmock UnpackStructImpl. 2022-07-25 dinor Add IsEmpty overload for C-style strings 2022-07-21 thegeorg Continuation for KhronosGroup#3183 2022-07-20 matdibu gtest-death-test: add 'noreturn' 2022-06-28 dev Set cmake policy CMP0069 2022-07-14 polushin export ThreadLocalValueHolderBase which is required by exported APIs. 2022-07-11 polushin cmake: make PDB output directory match that of a static library. 2022-07-11 polushin cmake: find python in order specified by PATH environment variable. 2022-07-11 dmauro Add envvar BAZEL_CXXOPTS=-std=c++14 to the GitHub Actions CI 2022-07-08 dmauro CMake: raise the default C++ standard to cxx_std_14 2022-07-07 ckennelly Enable heterogeneous lookup for RegisteredTestsMap. 2022-07-01 nikiforov.al cleanup from unique_ptr branch 2022-07-01 dmauro Remove the Bazel provided default cxxopt -std=c++0x and replace it with -std=c++14 when testing with GCC 5. 2022-07-01 57719497+yutotnh fix: some typos in source 2022-07-01 57719497+yutotnh fix: typo in test name 2022-07-01 57719497+yutotnh fix: some typos in comment 2022-06-30 dmauro Remove support for C++11 2022-06-30 dmauro Update version number in CMakeLists.txt Note that this is 1.12.1 as there will be a patch release to fix this 2022-06-29 absl-team Add support of 17-member structs to gmock UnpackStructImpl. 2022-06-27 absl-team Mark internal-only function as having internal linkage. 2022-06-27 93249401+assafpr Update gtest.cc 2022-06-27 93249401+assafpr Update gmock-matchers.h 2022-06-27 93249401+assafpr Update gmock-actions.h 2022-06-27 93249401+assafpr Update gmock-spec-builders_test.cc 2022-06-27 93249401+assafpr Update gtest-death-test.cc 2022-06-27 93249401+assafpr Update gmock-spec-builders.cc 2022-06-27 93249401+assafpr Update advanced.md 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-25 julian.arkenau docs: update googletest README for release 1.12.0 2022-06-23 dmauro Update README.md for release 1.12.0 2022-06-22 dmauro Update versions of WORKSPACE dependencies 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update faq.md 2022-06-22 93249401+assafpr Update CONTRIBUTING.md 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update gmock_output_test_golden.txt 2022-06-22 93249401+assafpr change link from master to main in documentation 2022-06-21 dmauro Update GCC floor container used by CI to fix the Bazel cache error 2022-06-16 dmauro Disable warning C4251 around refactored code 2022-06-13 absl-team gmock_cook_book.md: Delete superfluous statement from 2014. 2022-06-11 gpetit Move declaration of kStdOutFileNo and kStdErrFileno 2022-06-09 absl-team Update googletest docs to indicate that RE2 is now used for regexp implementation when building with Bazel and using Abseil. 2022-06-09 absl-team Remove undefined internal function. Fixes KhronosGroup#3856 2022-06-01 dmauro Work around a maybe-uninitialized warning under GCC 12 2022-05-31 gpetit Fix for undefined symbol: testing::internal::Random::kMaxRange 2022-05-30 gpetit Simplify ColoredPrintf to rely on ShouldUseColor 2022-05-30 gpetit Fix "unused variable" warning 2022-05-18 akohlmey set -utf-8 flag only for real MSVC compilers. E.g. not Intel's icx.exe 2022-03-26 perez.cs Fix quickstart-cmake documentation Created with: roll-dep external/googletest
google/googletest@548b13d...d9bb841 $ git log 548b13dc3..d9bb8412d --date=short --no-merges --format='%ad %ae %s' 2022-10-07 ferenc.gm Suggests a release with fixed CMakeLists.txt 2022-10-07 absl-team Update the POSIX Extended section of the Regular Expression Wikipedia page 2022-10-06 absl-team [fuchsia] Use __builtin_trap to trigger gunit_break_on_failure on non-x86 arch 2022-10-05 absl-team Makes Clang compilations via Ninja on Windows define _DLL only for shared CRT builds, as one would already expect from MSVC builds. (Previously, static Clang/Ninja builds on Windows also implicitly defined _DLL, which was problematic.) 2022-09-30 absl-team Uses a simpler mechanism to disable the copying of GoogleTest test suites, to move code out of the TEST_P macro. 2022-09-28 absl-team Rollback: Moves boilerplate disabling copy constructor/assignment from GoogleTest's TEST_P macro into a header file to avoid triggering warnings in user code. 2022-09-28 absl-team Rollback: Uses a simpler mechanism to disable the copying of GoogleTest test suites. 2022-09-28 absl-team Uses a simpler mechanism to disable the copying of GoogleTest test suites. 2022-09-28 absl-team Moves boilerplate disabling copy constructor/assignment from GoogleTest's TEST_P macro into a header file to avoid triggering warnings in user code. 2022-09-27 absl-team Add GoogleTest workaround for MSVC crash with Address Sanitizer (ASAN) on version 17.3.3 2022-09-27 cclauss Branding: macOS 2022-09-27 cclauss Upgrade GitHub Actions Checkout 2022-09-20 maratek Port GoogleTest to QuRT (Hexagon RTOS) 2022-09-18 426690+softwaregravy Update link to Bazel installation guide 2022-09-13 dmauro Fix MSVC C++14 flag for GitHub workflow 2022-09-13 dmauro Rollback 4fa8cfe3f4dee8975ee02d98633a5245ab67c6d7 2022-09-09 absl-team Use UnorderedElementsAre in example about using matchers with maps 2022-09-08 absl-team Remove obsolete MSVC warning pragmas for Invalid<T>() 2022-09-01 absl-team Fixed header guards to match style guide conventions. 2022-08-26 absl-team Consider all TERM values ending in "-256color" to be color supporting. In particular this handles TERM=hterm-256color correctly. 2022-08-22 hardikv Add support of 19-member structs to gmock UnpackStructImpl. 2022-08-19 keithbsmiley bazel: move -std=c++14 to .bazelrc 2022-08-16 dmauro Update README.md to point to the Foundational C++ Support Policy 2022-08-12 dmauro Add --features=external_include_paths to Bazel CI to ignore warnings from dependencies 2022-08-08 dinor gtest_unittest: Call FAIL() in lambda, fix incorrect fatality expectation 2022-08-04 dinor Explicitly instantiate matchee std::string in MatchesRegex 2022-07-31 bmburstein Custom type with Combine(). Fix for #3781 2022-07-28 absl-team Add support of 18-member structs to gmock UnpackStructImpl. 2022-07-25 dinor Add IsEmpty overload for C-style strings 2022-07-21 thegeorg Continuation for #3183 2022-07-20 matdibu gtest-death-test: add 'noreturn' 2022-06-28 dev Set cmake policy CMP0069 2022-07-14 polushin export ThreadLocalValueHolderBase which is required by exported APIs. 2022-07-11 polushin cmake: make PDB output directory match that of a static library. 2022-07-11 polushin cmake: find python in order specified by PATH environment variable. 2022-07-11 dmauro Add envvar BAZEL_CXXOPTS=-std=c++14 to the GitHub Actions CI 2022-07-08 dmauro CMake: raise the default C++ standard to cxx_std_14 2022-07-07 ckennelly Enable heterogeneous lookup for RegisteredTestsMap. 2022-07-01 nikiforov.al cleanup from unique_ptr branch 2022-07-01 dmauro Remove the Bazel provided default cxxopt -std=c++0x and replace it with -std=c++14 when testing with GCC 5. 2022-07-01 57719497+yutotnh fix: some typos in source 2022-07-01 57719497+yutotnh fix: typo in test name 2022-07-01 57719497+yutotnh fix: some typos in comment 2022-06-30 dmauro Remove support for C++11 2022-06-30 dmauro Update version number in CMakeLists.txt Note that this is 1.12.1 as there will be a patch release to fix this 2022-06-29 absl-team Add support of 17-member structs to gmock UnpackStructImpl. 2022-06-27 absl-team Mark internal-only function as having internal linkage. 2022-06-27 93249401+assafpr Update gtest.cc 2022-06-27 93249401+assafpr Update gmock-matchers.h 2022-06-27 93249401+assafpr Update gmock-actions.h 2022-06-27 93249401+assafpr Update gmock-spec-builders_test.cc 2022-06-27 93249401+assafpr Update gtest-death-test.cc 2022-06-27 93249401+assafpr Update gmock-spec-builders.cc 2022-06-27 93249401+assafpr Update advanced.md 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-25 julian.arkenau docs: update googletest README for release 1.12.0 2022-06-23 dmauro Update README.md for release 1.12.0 2022-06-22 dmauro Update versions of WORKSPACE dependencies 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update faq.md 2022-06-22 93249401+assafpr Update CONTRIBUTING.md 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update gmock_output_test_golden.txt 2022-06-22 93249401+assafpr change link from master to main in documentation 2022-06-21 dmauro Update GCC floor container used by CI to fix the Bazel cache error 2022-06-16 dmauro Disable warning C4251 around refactored code 2022-06-13 absl-team gmock_cook_book.md: Delete superfluous statement from 2014. 2022-06-11 gpetit Move declaration of kStdOutFileNo and kStdErrFileno 2022-06-09 absl-team Update googletest docs to indicate that RE2 is now used for regexp implementation when building with Bazel and using Abseil. 2022-06-09 absl-team Remove undefined internal function. Fixes #3856 2022-06-01 dmauro Work around a maybe-uninitialized warning under GCC 12 2022-05-31 gpetit Fix for undefined symbol: testing::internal::Random::kMaxRange 2022-05-30 gpetit Simplify ColoredPrintf to rely on ShouldUseColor 2022-05-30 gpetit Fix "unused variable" warning 2022-05-18 akohlmey set -utf-8 flag only for real MSVC compilers. E.g. not Intel's icx.exe 2022-03-26 perez.cs Fix quickstart-cmake documentation Created with: roll-dep external/googletest
google/googletest@v1.12.0...356fc30 $ git log v1.12.0..356fc3012 --date=short --no-merges --format='%ad %ae %s' 2023-01-12 tomhughes Fix -Wshadow warnings 2023-01-12 dmauro Add an explicit #error that C++ versions less than C++14 are not supported 2023-01-11 dmauro Update GoogleTest dependencies 2023-01-05 tomhughes Fix GTEST_OS_ESP8266 check 2023-01-05 tomhughes IWYU: Add missing std includes 2023-01-04 dmauro Workaround for GCC12 bug illustrated by https://godbolt.org/z/Pe5aE59xG 2023-01-04 tomhughes Fix _MSC_VER check 2022-12-22 absl-team Use a more recent commit of googletest that uses OS constraints from @platforms//os:* instead of from @build_tools//platforms:* 2022-12-20 absl-team Fix a typo in the documentation for "Using Predicates as Matchers". 2022-12-20 dinor Comment that q0_ in primer should remain empty 2022-12-19 absl-team Specify a name for a `Property` in a code example. 2022-12-15 absl-team Shut up a Clang warning. 2022-12-14 absl-team Fix a typo in the gMock sample code for Defining a Custom Matcher Class. 2022-12-12 dmauro Convert feature requests to a form 2022-12-12 absl-team Refactor matrix verification into VerifyMatchMatrix. 2022-12-12 absl-team Introduces a new porting flag (GTEST_HAS_FILE_SYSTEM) to indicate whether a platform supports filesystem operations. 2022-12-08 tomhughes Fall back to the system clock when building with newlib on a system without a monotonic clock. 2022-12-07 dmauro Migrate GoogleTest to a bug report template and add a link to the discussion forum for non-bugs 2022-12-05 dmauro Remove the unused class TestNameIs 2022-11-30 absl-team Make SizeIsMatcher::Impl conform to the contract of MatcherDescriberInterface. 2022-11-29 absl-team Disables `-Wunused-member-function` and `-Wused-but-marked-unused` that trigger via `MOCK_METHOD()` and `EXPECT_THAT()` macros. 2022-11-23 absl-team This commit fixes a minor verb conjugation error in gmock_cook_book.md. 2022-11-20 i Change MakeUnique -> std::make_unique in docs 2022-11-16 absl-team When printing floating-point numbers, print full precision by default. 2022-11-15 absl-team Remove incorrect usage of GTEST_ATTRIBUTE_UNUSED_ on classes. 2022-11-12 m.h1ch4m 2022-11-12 m.h1ch4m fixing gcc.gnu domain redirection 2022-11-11 absl-team Defined a testing::SrcDir() function that returns the name of a directory where ancillary data files can be found. 2022-11-10 i Support kitty TERM 2022-11-08 absl-team Remove incorrect GTEST_ATTRIBUTE_UNUSED_ from InSequence class. 2022-11-07 absl-team RecordProperty serializes ints and 64-bit ints, including size_ts 2022-11-05 absl-team Fix typo in documentation of ConvertGenerator() 2022-11-03 absl-team Add documentation for `--gunit_recreate_environments_when_repeating`. 2022-10-25 dinor Use git commit hash in CMake quickstart 2022-10-24 absl-team Clarify that parameter generator does not evaluate immediately 2022-10-21 i Fix format without expectation name 2022-10-21 i Change messages 2022-10-20 i Allow naming expectations KhronosGroup#3970 2022-10-18 absl-team CMake: Add GTEST_HAS_ABSL build option for using Absl 2022-10-18 absl-team Adds Win32 UNC path support to FilePath::IsAbsolutePath() and FilePath::IsRootDirectory() in GoogleTest 2022-10-17 dmauro Fix detection of the no_sanitize("hwaddress") attribute 2022-10-17 dinor Add Windows CI script 2022-10-16 i Add return for GTEST_FAIL_AT 2022-10-14 dmauro Use attribute testing to simplify portable attribute macros 2022-10-14 absl-team Terse printing of std::reference_wrapper hides pointer 2022-10-14 janbruckner Fix table markup in testing.md 2022-10-12 absl-team Workaround for Visual C++ error C2039 with std::tuple_element_t. 2022-10-11 i Fix JSON output format KhronosGroup#3884 2022-10-07 ferenc.gm Suggests a release with fixed CMakeLists.txt 2022-10-08 julian.amann Update rules_python, bazel_skylib and platfroms (...) 2022-09-01 absl-team Fixed header guards to match style guide conventions. 2022-08-26 absl-team Consider all TERM values ending in "-256color" to be color supporting. In particular this handles TERM=hterm-256color correctly. 2022-08-22 hardikv Add support of 19-member structs to gmock UnpackStructImpl. 2022-08-19 keithbsmiley bazel: move -std=c++14 to .bazelrc 2022-08-16 dmauro Update README.md to point to the Foundational C++ Support Policy 2022-08-12 dmauro Add --features=external_include_paths to Bazel CI to ignore warnings from dependencies 2022-08-08 dinor gtest_unittest: Call FAIL() in lambda, fix incorrect fatality expectation 2022-08-04 dinor Explicitly instantiate matchee std::string in MatchesRegex 2022-07-31 bmburstein Custom type with Combine(). Fix for KhronosGroup#3781 2022-07-28 absl-team Add support of 18-member structs to gmock UnpackStructImpl. 2022-07-25 dinor Add IsEmpty overload for C-style strings 2022-07-21 thegeorg Continuation for KhronosGroup#3183 2022-07-20 matdibu gtest-death-test: add 'noreturn' 2022-06-28 dev Set cmake policy CMP0069 2022-07-14 polushin export ThreadLocalValueHolderBase which is required by exported APIs. 2022-07-11 polushin cmake: make PDB output directory match that of a static library. 2022-07-11 polushin cmake: find python in order specified by PATH environment variable. 2022-07-11 dmauro Add envvar BAZEL_CXXOPTS=-std=c++14 to the GitHub Actions CI 2022-07-08 dmauro CMake: raise the default C++ standard to cxx_std_14 2022-07-07 ckennelly Enable heterogeneous lookup for RegisteredTestsMap. 2022-07-01 nikiforov.al cleanup from unique_ptr branch 2022-07-01 dmauro Remove the Bazel provided default cxxopt -std=c++0x and replace it with -std=c++14 when testing with GCC 5. 2022-07-01 57719497+yutotnh fix: some typos in source 2022-07-01 57719497+yutotnh fix: typo in test name 2022-07-01 57719497+yutotnh fix: some typos in comment 2022-06-30 dmauro Remove support for C++11 2022-06-30 dmauro Update version number in CMakeLists.txt Note that this is 1.12.1 as there will be a patch release to fix this 2022-06-29 absl-team Add support of 17-member structs to gmock UnpackStructImpl. 2022-06-27 absl-team Mark internal-only function as having internal linkage. 2022-06-27 93249401+assafpr Update gtest.cc 2022-06-27 93249401+assafpr Update gmock-matchers.h 2022-06-27 93249401+assafpr Update gmock-actions.h 2022-06-27 93249401+assafpr Update gmock-spec-builders_test.cc 2022-06-27 93249401+assafpr Update gtest-death-test.cc 2022-06-27 93249401+assafpr Update gmock-spec-builders.cc 2022-06-27 93249401+assafpr Update advanced.md 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-25 julian.arkenau docs: update googletest README for release 1.12.0 2022-06-23 dmauro Update README.md for release 1.12.0 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update faq.md 2022-06-22 93249401+assafpr Update CONTRIBUTING.md 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update gmock_output_test_golden.txt 2022-06-22 93249401+assafpr change link from master to main in documentation 2022-05-31 gpetit Fix for undefined symbol: testing::internal::Random::kMaxRange 2022-05-18 akohlmey set -utf-8 flag only for real MSVC compilers. E.g. not Intel's icx.exe 2022-03-26 perez.cs Fix quickstart-cmake documentation Created with: roll-dep external/googletest
* Roll external/effcee/ 35912e1b7..c7b4db79f (1 commit) google/effcee@35912e1...c7b4db7 $ git log 35912e1b7..c7b4db79f --date=short --no-merges --format='%ad %ae %s' 2022-12-20 dneto Update Bazel external dependencies Created with: roll-dep external/effcee * Roll external/googletest/ v1.12.0..356fc3012 (117 commits) google/googletest@v1.12.0...356fc30 $ git log v1.12.0..356fc3012 --date=short --no-merges --format='%ad %ae %s' 2023-01-12 tomhughes Fix -Wshadow warnings 2023-01-12 dmauro Add an explicit #error that C++ versions less than C++14 are not supported 2023-01-11 dmauro Update GoogleTest dependencies 2023-01-05 tomhughes Fix GTEST_OS_ESP8266 check 2023-01-05 tomhughes IWYU: Add missing std includes 2023-01-04 dmauro Workaround for GCC12 bug illustrated by https://godbolt.org/z/Pe5aE59xG 2023-01-04 tomhughes Fix _MSC_VER check 2022-12-22 absl-team Use a more recent commit of googletest that uses OS constraints from @platforms//os:* instead of from @build_tools//platforms:* 2022-12-20 absl-team Fix a typo in the documentation for "Using Predicates as Matchers". 2022-12-20 dinor Comment that q0_ in primer should remain empty 2022-12-19 absl-team Specify a name for a `Property` in a code example. 2022-12-15 absl-team Shut up a Clang warning. 2022-12-14 absl-team Fix a typo in the gMock sample code for Defining a Custom Matcher Class. 2022-12-12 dmauro Convert feature requests to a form 2022-12-12 absl-team Refactor matrix verification into VerifyMatchMatrix. 2022-12-12 absl-team Introduces a new porting flag (GTEST_HAS_FILE_SYSTEM) to indicate whether a platform supports filesystem operations. 2022-12-08 tomhughes Fall back to the system clock when building with newlib on a system without a monotonic clock. 2022-12-07 dmauro Migrate GoogleTest to a bug report template and add a link to the discussion forum for non-bugs 2022-12-05 dmauro Remove the unused class TestNameIs 2022-11-30 absl-team Make SizeIsMatcher::Impl conform to the contract of MatcherDescriberInterface. 2022-11-29 absl-team Disables `-Wunused-member-function` and `-Wused-but-marked-unused` that trigger via `MOCK_METHOD()` and `EXPECT_THAT()` macros. 2022-11-23 absl-team This commit fixes a minor verb conjugation error in gmock_cook_book.md. 2022-11-20 i Change MakeUnique -> std::make_unique in docs 2022-11-16 absl-team When printing floating-point numbers, print full precision by default. 2022-11-15 absl-team Remove incorrect usage of GTEST_ATTRIBUTE_UNUSED_ on classes. 2022-11-12 m.h1ch4m 2022-11-12 m.h1ch4m fixing gcc.gnu domain redirection 2022-11-11 absl-team Defined a testing::SrcDir() function that returns the name of a directory where ancillary data files can be found. 2022-11-10 i Support kitty TERM 2022-11-08 absl-team Remove incorrect GTEST_ATTRIBUTE_UNUSED_ from InSequence class. 2022-11-07 absl-team RecordProperty serializes ints and 64-bit ints, including size_ts 2022-11-05 absl-team Fix typo in documentation of ConvertGenerator() 2022-11-03 absl-team Add documentation for `--gunit_recreate_environments_when_repeating`. 2022-10-25 dinor Use git commit hash in CMake quickstart 2022-10-24 absl-team Clarify that parameter generator does not evaluate immediately 2022-10-21 i Fix format without expectation name 2022-10-21 i Change messages 2022-10-20 i Allow naming expectations #3970 2022-10-18 absl-team CMake: Add GTEST_HAS_ABSL build option for using Absl 2022-10-18 absl-team Adds Win32 UNC path support to FilePath::IsAbsolutePath() and FilePath::IsRootDirectory() in GoogleTest 2022-10-17 dmauro Fix detection of the no_sanitize("hwaddress") attribute 2022-10-17 dinor Add Windows CI script 2022-10-16 i Add return for GTEST_FAIL_AT 2022-10-14 dmauro Use attribute testing to simplify portable attribute macros 2022-10-14 absl-team Terse printing of std::reference_wrapper hides pointer 2022-10-14 janbruckner Fix table markup in testing.md 2022-10-12 absl-team Workaround for Visual C++ error C2039 with std::tuple_element_t. 2022-10-11 i Fix JSON output format #3884 2022-10-07 ferenc.gm Suggests a release with fixed CMakeLists.txt 2022-10-08 julian.amann Update rules_python, bazel_skylib and platfroms (...) 2022-09-01 absl-team Fixed header guards to match style guide conventions. 2022-08-26 absl-team Consider all TERM values ending in "-256color" to be color supporting. In particular this handles TERM=hterm-256color correctly. 2022-08-22 hardikv Add support of 19-member structs to gmock UnpackStructImpl. 2022-08-19 keithbsmiley bazel: move -std=c++14 to .bazelrc 2022-08-16 dmauro Update README.md to point to the Foundational C++ Support Policy 2022-08-12 dmauro Add --features=external_include_paths to Bazel CI to ignore warnings from dependencies 2022-08-08 dinor gtest_unittest: Call FAIL() in lambda, fix incorrect fatality expectation 2022-08-04 dinor Explicitly instantiate matchee std::string in MatchesRegex 2022-07-31 bmburstein Custom type with Combine(). Fix for #3781 2022-07-28 absl-team Add support of 18-member structs to gmock UnpackStructImpl. 2022-07-25 dinor Add IsEmpty overload for C-style strings 2022-07-21 thegeorg Continuation for #3183 2022-07-20 matdibu gtest-death-test: add 'noreturn' 2022-06-28 dev Set cmake policy CMP0069 2022-07-14 polushin export ThreadLocalValueHolderBase which is required by exported APIs. 2022-07-11 polushin cmake: make PDB output directory match that of a static library. 2022-07-11 polushin cmake: find python in order specified by PATH environment variable. 2022-07-11 dmauro Add envvar BAZEL_CXXOPTS=-std=c++14 to the GitHub Actions CI 2022-07-08 dmauro CMake: raise the default C++ standard to cxx_std_14 2022-07-07 ckennelly Enable heterogeneous lookup for RegisteredTestsMap. 2022-07-01 nikiforov.al cleanup from unique_ptr branch 2022-07-01 dmauro Remove the Bazel provided default cxxopt -std=c++0x and replace it with -std=c++14 when testing with GCC 5. 2022-07-01 57719497+yutotnh fix: some typos in source 2022-07-01 57719497+yutotnh fix: typo in test name 2022-07-01 57719497+yutotnh fix: some typos in comment 2022-06-30 dmauro Remove support for C++11 2022-06-30 dmauro Update version number in CMakeLists.txt Note that this is 1.12.1 as there will be a patch release to fix this 2022-06-29 absl-team Add support of 17-member structs to gmock UnpackStructImpl. 2022-06-27 absl-team Mark internal-only function as having internal linkage. 2022-06-27 93249401+assafpr Update gtest.cc 2022-06-27 93249401+assafpr Update gmock-matchers.h 2022-06-27 93249401+assafpr Update gmock-actions.h 2022-06-27 93249401+assafpr Update gmock-spec-builders_test.cc 2022-06-27 93249401+assafpr Update gtest-death-test.cc 2022-06-27 93249401+assafpr Update gmock-spec-builders.cc 2022-06-27 93249401+assafpr Update advanced.md 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-26 asmodai27 Avoid implicit conversion from int to char 2022-06-25 julian.arkenau docs: update googletest README for release 1.12.0 2022-06-23 dmauro Update README.md for release 1.12.0 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update faq.md 2022-06-22 93249401+assafpr Update CONTRIBUTING.md 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr documentation, change mater branch to main 2022-06-22 93249401+assafpr Update gmock_output_test_golden.txt 2022-06-22 93249401+assafpr change link from master to main in documentation 2022-05-31 gpetit Fix for undefined symbol: testing::internal::Random::kMaxRange 2022-05-18 akohlmey set -utf-8 flag only for real MSVC compilers. E.g. not Intel's icx.exe 2022-03-26 perez.cs Fix quickstart-cmake documentation Created with: roll-dep external/googletest * Roll external/re2/ d2836d1b1..954656f47 (13 commits) google/re2@d2836d1...954656f $ git log d2836d1b1..954656f47 --date=short --no-merges --format='%ad %ae %s' 2022-12-07 junyer Restore the "lock counter" option for `Mutex`. 2022-11-29 junyer Avoid "immortal" dynamic memory allocations. 2022-11-23 junyer Drop old compiler versions from the build matrix. 2022-11-22 junyer Control the maximum count permitted by `GlobalReplace()`. 2022-11-20 junyer Specify just the MAJOR.MINOR components to `cmake_minimum_required()`. 2022-11-18 junyer Install `re2.pc` with CMake too. 2022-10-26 junyer Reword some comments in `re2.h`. 2022-10-17 junyer Add the no-op GitHub Actions workflow for Python releases. 2022-10-17 junyer Revert "Add a GitHub Actions workflow for Python releases." 2022-10-17 junyer Add a GitHub Actions workflow for Python releases. 2022-10-17 junyer Revert "Add a GitHub Actions workflow for Python releases." 2022-10-14 junyer Add a GitHub Actions workflow for Python releases. 2022-10-14 junyer Bump versions of actions to address warnings. Created with: roll-dep external/re2 * Update CHANGES * Fix release name * Revert "Roll external/googletest/ v1.12.0..356fc3012 (117 commits)" This reverts commit 45f5de6. Rolling back this update to googletest to prevent build failures. Our CI systems are still assuming C++0x support. Post release, SPIRV-Tools will move to require C++17 minimum.
* Rolling 5 dependencies Roll third_party/glslang/ 4b2483e..1f0fcbe (9 commits) KhronosGroup/glslang@4b2483e...1f0fcbe $ git log 4b2483e..1f0fcbe --date=short --no-merges --format='%ad %ae %s' 2020-03-21 arnfranke Make file formatting comply with POSIX and Unix standards 2020-03-19 courtneygo Fix MSVC build issue - remove invalid character 2020-03-18 alele Re-add NV enums for raytracing to prevent build breaks. 2020-03-18 cepheus Fix KhronosGroup#2132: constant matrix constructor from single non-scalar argument 2020-03-18 cepheus Bump version (also fix line endings the grammar). 2020-03-17 dkoch update known_good 2020-03-17 dkoch Add support for GLSL_EXT_ray_tracing 2020-03-17 cepheus SPV headers: Bump up to the latest header. 2020-03-16 jbolz Forbid memoryBarrierAtomicCounter for Vulkan compiles Roll third_party/googletest/ e588eb1ff..749148f1a (10 commits) google/googletest@e588eb1...749148f $ git log e588eb1ff..749148f1a --date=short --no-merges --format='%ad %ae %s' 2020-03-20 absl-team Googletest export 2020-03-17 absl-team Googletest export 2020-03-16 dmauro Googletest export 2020-03-13 absl-team Googletest export 2020-03-06 absl-team Googletest export 2020-03-03 absl-team Googletest export 2020-03-03 absl-team Googletest export 2020-03-11 romain.geissler Make sure IsATTY does not clobber errno. 2020-02-21 johan.mabille Fixed warnings 2020-01-29 krystian.kuzniarek remove a dead reference to the Autotools script Roll third_party/spirv-cross/ 65aa0c35d..871c85d7f (4 commits) KhronosGroup/SPIRV-Cross@65aa0c3...871c85d $ git log 65aa0c35d..871c85d7f --date=short --no-merges --format='%ad %ae %s' 2020-03-19 post GLSL: Implement GL_EXT_shader_framebuffer_fetch. 2020-03-19 post Run format_all.sh. 2020-03-19 post GLSL/HLSL: Fix nonuniform qualifier for SSBO atomics. 2020-03-19 post GLSL/HLSL: Implement nonuniform qualifier for image atomics. Roll third_party/spirv-headers/ a17e17e..f8bf11a (5 commits) KhronosGroup/SPIRV-Headers@a17e17e...f8bf11a $ git log a17e17e..f8bf11a --date=short --no-merges --format='%ad %ae %s' 2020-03-17 dkoch Add shadercalls scope 2020-03-03 ntorosda Added ray flags, primitive culling flags, queries 2020-03-17 cepheus Non-functional: Update header build to match Khronos spec. builder. 2020-02-14 alele Update headers for SPV_KHR_ray_tracing. 2020-01-01 xanto Also propagate SPIRV-Headers version to CMakeLists.txt Roll third_party/spirv-tools/ 25ede1c..1c8bda3 (7 commits) KhronosGroup/SPIRV-Tools@25ede1c...1c8bda3 $ git log 25ede1c..1c8bda3 --date=short --no-merges --format='%ad %ae %s' 2020-03-23 jaebaek Add data structure for DebugScope, DebugDeclare in spirv-opt (KhronosGroup#3183) 2020-03-23 ehsannas Whitelist SPV_KHR_ray_tracing (KhronosGroup#3241) 2020-03-23 arnfranke Make file formatting comply with POSIX standards (KhronosGroup#3242) 2020-03-19 dneto Add opt::Operand::AsCString and AsString (KhronosGroup#3240) 2020-03-20 lujiao Add RayQueryProvisionalKHR to opt types (KhronosGroup#3239) 2020-03-17 ehsannas Whitelist SPV_EXT_demote_to_helper_invocation for opt passes (KhronosGroup#3236) 2020-03-17 dgkoch Add support for KHR_ray_{query,tracing} extensions (KhronosGroup#3235) Created with: roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools * Updated expectations
This commit adds data structures for rich debug info and lets ir_loader
and module correctly load/dump IR instructions.
DebugScope,DebugNoScope,DebugDeclare,DebugValue, we already addedInstructionList ext_inst_debuginfo_inModuleclass.DebugScope/DebugNoScope, this commit addsstruct DebugScopeinInstructionclass.DebugScope/DebugNoScope, we updatelast_dbg_scope_of ir_loader to update the lastDebugScopeinformation. When ir_loader processes a terminator instruction or merge
instruction, it sets
last_dbg_scope_asDebugNoScopebecause it is theend of the scope. When module dumps IR, if the next
DebugScopeis newscope information, it generates a
DebugScopeinstruction. If the nextDebugScopedenotes the end of a scope, it generates aDebugNoScopeinstruction.
DebugDeclare, this commit addsstd::map<uint32_t, std::unique_ptr<Instruction>> local_var_to_dbg_decl_that is a map between each result id of local variable and its
corresponding
DebugDeclare. When we remove a local variable, we canremove
DebugDeclareand add a newDebugValueinInstructionListof basic block like a normal instruction.