Validator: Support VK_EXT_scalar_block_layout - #2074
Closed
dneto0 wants to merge 4 commits into
Closed
Conversation
Collaborator
Author
|
I expect the shaderc smoke test to fail because this MR changes the validation message to be more specific about which layout rules are in effect. This is the one change to the Glslang validation results in its baseResults. (Basically "standard" -> "relaxed") cc: @johnkslang This will be another update to the Glslang base results validation output. |
alan-baker
requested changes
Nov 16, 2018
alan-baker
left a comment
alan-baker
left a comment
Contributor
There was a problem hiding this comment.
I think you need a test for an otherwise unacceptable array stride. Something like putting an array of a struct of float3 in a uniform buffer. The array stride should be 12 instead of 16.
9 tasks
Adds validator option to specify scalar block layout rules. Both VK_KHR_relax_block_layout and VK_EXT_scalar_block_layout can be enabled at the same time. But scalar block layout is as permissive as relax block layout. Also, scalar block layout does not require padding at the end of a struct. Cleanup: The internal getSize method does not need a round-up argument, so remove it.
dneto0
force-pushed
the
dneto-vk-ext-scalar-block-layout
branch
from
November 16, 2018 20:06
f36524e to
5c5da85
Compare
alan-baker
approved these changes
Nov 16, 2018
Collaborator
Author
|
Rebased and pushed into master as 8e9be30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds validator option to specify scalar block layout rules.
Both VK_KHR_relax_block_layout and VK_EXT_scalar_block_layout can be
enabled at the same time. But scalar block layout is as permissive
as relax block layout.
Also, scalar block layout does not require padding at the end of a
struct.
Cleanup: The internal getSize method does not need a round-up argument,
so remove it.
FYI: This is part of the rollout of VK_EXT_scalar_block_layout: KhronosGroup/Vulkan-Docs#854