Skip to content

Conversation

@pierremoreau
Copy link
Contributor

Fixes: #1144

@pierremoreau
Copy link
Contributor Author

The RelWithDebInfo build using g++ timed out, but all the other builds were successful.

@antiagainst
Copy link
Contributor

Hmm... It seems the performance of the Travis infrastructure is fluctuating again.

I restarted that job. Let's see what will happen.

@pierremoreau
Copy link
Contributor Author

Thanks for restarting the job. I had some timeout on another pull request, but I need to fix some formatting, so that will restart the job there.

@pierremoreau
Copy link
Contributor Author

Still the same build failing, but this time it is due to one of the unit test (spirv-tools-test_spirv_unit_tests), however that test is also failing on master.

@dneto0
Copy link
Collaborator

dneto0 commented Feb 27, 2018

I suspect the conflict is a trivial conflict with the --verify-ids change. I can resolve that locally.

@pierremoreau
Copy link
Contributor Author

I would guess so as well; I initially had this series on top of the verify-ids one, and rebasing it onto master led to some conflicts, but I thought I was still better to have them separate.
Thanks for the review.

@dneto0
Copy link
Collaborator

dneto0 commented Feb 27, 2018

Rebased, resolved conflict, and pushed into master as bdd6617

@dneto0 dneto0 closed this Feb 27, 2018
@pierremoreau pierremoreau deleted the allow_partial_linkage branch February 27, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants