Add primitive instruction validation pass#1095
Closed
jeremy-lunarg wants to merge 1 commit intoKhronosGroup:masterfrom
Closed
Add primitive instruction validation pass#1095jeremy-lunarg wants to merge 1 commit intoKhronosGroup:masterfrom
jeremy-lunarg wants to merge 1 commit intoKhronosGroup:masterfrom
Conversation
|
|
dneto0
approved these changes
Dec 15, 2017
Collaborator
dneto0
left a comment
dneto0
left a comment
There was a problem hiding this comment.
It would have been nice to see success test cases for the EmitVertex and EndPrimitive instructions. The binary parser and other general parts of the validator take care of it, but it would be nice to have receipts. :-)
The bot failure is a small formatting problem. We can take care of that before submission.
Collaborator
|
I reformatted the one line, then committed to master as cdfbf26 |
atgoo
reviewed
Dec 18, 2017
|
|
||
| namespace libspirv { | ||
|
|
||
| // Validates correctness of composite instructions. |
| switch (opcode) { | ||
| case SpvOpEmitStreamVertex: | ||
| case SpvOpEndStreamPrimitive: { | ||
| const uint32_t stream_type = _.GetOperandTypeId(inst, 0); |
There was a problem hiding this comment.
There is also function _.GetTypeId(id). (since you already have variable stream_id).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.