Here's a SPIR-V that can reproduce the validation failure that was relaxed in #2420

               OpCapability Shader
               OpMemoryModel Logical GLSL450
               OpEntryPoint Fragment %main "main" %out_var_SV_Target
               OpExecutionMode %main OriginUpperLeft
               OpSource HLSL 600
               OpName %out_var_SV_Target "out.var.SV_Target"
               OpName %main "main"
               OpName %src_main "src.main"
               OpName %bb_entry "bb.entry"
               OpName %T "T"
               OpMemberName %T 0 "ro"
               OpName %type_StructuredBuffer_v4float "type.StructuredBuffer.v4float"
               OpName %t "t"
               OpName %param_var_t "param.var.t"
               OpName %foo "foo"
               OpName %t_0 "t"
               OpName %bb_entry_0 "bb.entry"
               OpDecorate %out_var_SV_Target Location 0
               OpDecorate %_runtimearr_v4float ArrayStride 16
               OpMemberDecorate %type_StructuredBuffer_v4float 0 Offset 0
               OpMemberDecorate %type_StructuredBuffer_v4float 0 NonWritable
               OpDecorate %type_StructuredBuffer_v4float BufferBlock
        %int = OpTypeInt 32 1
      %int_0 = OpConstant %int 0
       %uint = OpTypeInt 32 0
     %uint_0 = OpConstant %uint 0
      %float = OpTypeFloat 32
    %v4float = OpTypeVector %float 4
%_ptr_Output_v4float = OpTypePointer Output %v4float
       %void = OpTypeVoid
         %11 = OpTypeFunction %void
         %15 = OpTypeFunction %v4float
%_runtimearr_v4float = OpTypeRuntimeArray %v4float
%type_StructuredBuffer_v4float = OpTypeStruct %_runtimearr_v4float
%_ptr_Uniform_type_StructuredBuffer_v4float = OpTypePointer Uniform %type_StructuredBuffer_v4float
          %T = OpTypeStruct %_ptr_Uniform_type_StructuredBuffer_v4float
%_ptr_Function_T = OpTypePointer Function %T
         %27 = OpTypeFunction %v4float %_ptr_Function_T
%_ptr_Function__ptr_Uniform_type_StructuredBuffer_v4float = OpTypePointer Function %_ptr_Uniform_type_StructuredBuffer_v4float
%_ptr_Uniform_v4float = OpTypePointer Uniform %v4float
%out_var_SV_Target = OpVariable %_ptr_Output_v4float Output
       %main = OpFunction %void None %11
         %12 = OpLabel
         %13 = OpFunctionCall %v4float %src_main
               OpStore %out_var_SV_Target %13
               OpReturn
               OpFunctionEnd
   %src_main = OpFunction %v4float None %15
   %bb_entry = OpLabel
          %t = OpVariable %_ptr_Function_T Function
%param_var_t = OpVariable %_ptr_Function_T Function
         %24 = OpLoad %T %t
               OpStore %param_var_t %24
         %25 = OpFunctionCall %v4float %foo %param_var_t
               OpReturnValue %25
               OpFunctionEnd
        %foo = OpFunction %v4float None %27
        %t_0 = OpFunctionParameter %_ptr_Function_T
 %bb_entry_0 = OpLabel
         %31 = OpAccessChain %_ptr_Function__ptr_Uniform_type_StructuredBuffer_v4float %t_0 %int_0
         %32 = OpLoad %_ptr_Uniform_type_StructuredBuffer_v4float %31
         %34 = OpAccessChain %_ptr_Uniform_v4float %32 %int_0 %uint_0
         %35 = OpLoad %v4float %34
               OpReturnValue %35
               OpFunctionEnd

This was generated for the following HLSL shader:

struct T {
  StructuredBuffer<float4> ro;
};

float4 foo(T t) {
    return t.ro[0];
}

float4 main() : SV_Target {
  T t;
  return foo(t);
}

Without that change, we were getting this error:

fatal error: generated SPIR-V is invalid:
Target of NonWritable member decoration is invalid: 
must be the struct type of a uniform block or storage buffer
  %type_StructuredBuffer_v4float = OpTypeStruct %_runtimearr_v4float

Revisit validation of NonWritable decoration #2421

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions