Fix assert for structs with no decorations#58
Merged
chaoticbob merged 1 commit intoKhronosGroup:masterfrom Jul 26, 2018
Merged
Conversation
Previously, if a shader didn't decorate all the members (or specifically, the last member) with any decorations/names, an assert would trigger in ParseTypes because the OpTypeStruct's member_count would be 0. This fixes that by hardcoding member count for Struct types to word_count - 2 (based on the binary encoding of OpTypeStruct).
sean-purcell
added a commit
to sean-purcell/gapid
that referenced
this pull request
Jul 18, 2018
SPIRV-Reflect offers tools to analyze the interface exposed by a spirv module. It's used here to parse the descriptor sets that a given entry point of a module uses. NOTE: Upstream is currently iburinoc/SPIRV-Reflect, this should be switched to chaoticbob/SPIRV-Reflect once KhronosGroup/SPIRV-Reflect#56 and KhronosGroup/SPIRV-Reflect#58 are merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a shader didn't decorate all the members (or
specifically, the last member) with any decorations/names,
an assert would trigger in ParseTypes because the OpTypeStruct's
member_count would be 0. This fixes that by hardcoding member count for
Struct types to word_count - 2 (based on the binary encoding of
OpTypeStruct).