This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Merged
Conversation
This upgrade includes a wasmtime-go fix for a linker bug on Linux where the pthread library wasn't linked and caused builds to fail on Linux. The upgrade to wasmtime-go v0.29 also includes a migration to wasmtime's new C api (bytecodealliance/rfcs#11)
Collaborator
Author
|
@avidal Not sure you're still involved in Fastlike, but thought I'd also ping you in case this interests you. |
Contributor
|
I am, thanks! I also watch issues on the wasmtime-go repo so I saw the report pop in. fastlike.dev is a couple of releases behind wasmtime-go at this point so it should be safe until I get around to updating. |
jaredly
approved these changes
Aug 4, 2021
jaredly
left a comment
jaredly
left a comment
There was a problem hiding this comment.
looks reasonable, thanks for upgrading!
…tyle calls, so now it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A linker issue in wasmtime-go caused build failures in Linux environments. This was fixed and shipped in v0.29 and so we need to upgrade.
This upgrade includes a wasmtime-go fix for a linker bug on Linux where the pthread library wasn't linked and caused builds to fail on Linux.
The upgrade to wasmtime-go v0.29 also includes a migration to wasmtime's new C api (bytecodealliance/rfcs#11)
The changes were largely guided by the RFC and the example code.
Issue: LP-10085
Test plan:
make test