Skip to content
This repository was archived by the owner on Jan 25, 2025. It is now read-only.

Onboarding bugfixes#10

Merged
nimish-ks merged 13 commits intomainfrom
onboarding-bugfixes
Dec 23, 2022
Merged

Onboarding bugfixes#10
nimish-ks merged 13 commits intomainfrom
onboarding-bugfixes

Conversation

@0x4f53
Copy link
Copy Markdown
Member

@0x4f53 0x4f53 commented Dec 22, 2022

Fixed several bugs in StartHere.kt, including:

  • A bug where the backend would return a 500 when signing in despite authenticating successfully.
  • A bug where the app would crash after making an account, due to a redundant API call.
  • Bugs where the app would crash when any exception was thrown (due to issues with supportFragmentManager).
  • Visual bug on the tap words screen where tapping on a wrong word would cause the whole screen to move around.
  • Sped up animations to strike balance between prettiness and functionality.
  • Modified progress icon sizes to make them more consistent.
  • Simplified code in StartHere.kt and NetworkUtilities.kt.

@0x4f53 0x4f53 requested review from a user and nimish-ks December 22, 2022 17:25
Copy link
Copy Markdown
Member

@nimish-ks nimish-ks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go

@nimish-ks nimish-ks merged commit ef32497 into main Dec 23, 2022
@nimish-ks nimish-ks deleted the onboarding-bugfixes branch December 23, 2022 06:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants