Repository navigation
Commit adee4d2
fix(telemetry): remove redundant captureException calls that double-count errors (Zoo-Code-Org#1702)
* fix(telemetry): remove redundant captureException calls that double-count errors
Issue Zoo-Code-Org#513 identified captureException sites where the same error is
captured again downstream or where a named telemetry event already
carries the signal:
- Task.ts: captureException(new ConsecutiveMistakeError(...)) fired
right after captureConsecutiveMistakeError(), routing a deliberate
control-flow limit into error tracking as a duplicate.
- presentAssistantMessage.ts: same redundant pairing for the
tool_repetition guard.
- openai-native.ts: handleStreamResponse captured stream-processing
failures and rethrew, after which createMessage's catch captured the
same failure again.
The openrouter handleStreamingError capture was left in place: in
current code its rethrown error is not captured anywhere downstream
(createMessage has no enclosing catch for the stream loop and
completePrompt invokes it outside its try/catch), so removing it would
drop the only capture for mid-stream OpenRouter errors.
* fix(telemetry): send reason, count and limit on consecutive mistake event
* fix(telemetry): report accurate reason and count on consecutive mistake event
---------
Co-authored-by: Zoo (VP) <[email protected]>
Co-authored-by: Elliott de Launay <[email protected]>1 parent fafad20 commit adee4d2
7 files changed
Lines changed: 89 additions & 40 deletions
File tree
- packages/telemetry/src
- __tests__
- src
- api/providers
- __tests__
- core
- assistant-message
- __tests__
- task
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
280 | 281 | | |
281 | 282 | | |
282 | 283 | | |
283 | | - | |
284 | | - | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
285 | 296 | | |
286 | 297 | | |
287 | 298 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1566 | 1566 | | |
1567 | 1567 | | |
1568 | 1568 | | |
1569 | | - | |
1570 | | - | |
| 1569 | + | |
| 1570 | + | |
1571 | 1571 | | |
1572 | | - | |
1573 | 1572 | | |
1574 | 1573 | | |
1575 | 1574 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1129 | 1129 | | |
1130 | 1130 | | |
1131 | 1131 | | |
1132 | | - | |
1133 | | - | |
1134 | | - | |
1135 | | - | |
| 1132 | + | |
| 1133 | + | |
1136 | 1134 | | |
1137 | 1135 | | |
1138 | 1136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
300 | | - | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
301 | 306 | | |
302 | 307 | | |
303 | 308 | | |
| |||
361 | 366 | | |
362 | 367 | | |
363 | 368 | | |
364 | | - | |
365 | | - | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
366 | 377 | | |
367 | 378 | | |
368 | 379 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
835 | 835 | | |
836 | 836 | | |
837 | 837 | | |
838 | | - | |
839 | | - | |
840 | | - | |
841 | | - | |
842 | | - | |
843 | | - | |
844 | | - | |
845 | | - | |
846 | | - | |
847 | | - | |
848 | | - | |
849 | | - | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
850 | 847 | | |
851 | 848 | | |
852 | 849 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
| |||
3782 | 3781 | | |
3783 | 3782 | | |
3784 | 3783 | | |
3785 | | - | |
3786 | | - | |
3787 | | - | |
3788 | | - | |
3789 | | - | |
3790 | | - | |
3791 | | - | |
3792 | | - | |
3793 | | - | |
3794 | | - | |
3795 | | - | |
3796 | | - | |
3797 | | - | |
3798 | | - | |
| 3784 | + | |
| 3785 | + | |
| 3786 | + | |
| 3787 | + | |
| 3788 | + | |
| 3789 | + | |
| 3790 | + | |
| 3791 | + | |
3799 | 3792 | | |
3800 | 3793 | | |
3801 | 3794 | | |
| |||
0 commit comments