Support RedisClientMasterSlaves#295
Merged
Merged
Conversation
KarelCemus
reviewed
Apr 5, 2024
KarelCemus
left a comment
Owner
There was a problem hiding this comment.
Hello, thank you for your contribution, nice PR. I have just one small note, if you could fix it, then I'd merge it and release it.
alexmihailov
force-pushed
the
feature/master-slave
branch
from
April 8, 2024 06:59
fc9474f to
cd6a1ca
Compare
KarelCemus
reviewed
Apr 8, 2024
alexmihailov
force-pushed
the
feature/master-slave
branch
from
April 8, 2024 20:26
cd6a1ca to
30de987
Compare
KarelCemus
approved these changes
Apr 10, 2024
Owner
|
Releasing as 4.1.0, thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases, there is a need to write data to the master, and read from one of the slave nodes. The rediscala library supports such functionality using class
redis.RedisClientMasterSlaves. I implemented support forRedisClientMasterSlavesby specifying the configurationsource: master-slaves. Example: