feat: Support \textsc via small caps font cmcsc10#3085
feat: Support \textsc via small caps font cmcsc10#3085benrbray wants to merge 3 commits intoKaTeX:mainfrom
\textsc via small caps font cmcsc10#3085Conversation
|
Based on the failing automated test artifacts, the new small caps font overrides the default font in some cases. There are also some strange spacing issues. I'll investigate myself, but any help would certainly be appreciated. Thanks! |
|
The new commit fixes the font override issue. According to the CSS spec, the The generated character mappings still need some attention, and the automated tests will reveal whether this fixed the spacing issues. |
\textsc via small caps font cmcsc10\textsc via small caps font cmcsc10
|
This PR is ready for review, no rush though. (the tasklist just has some questions that need attention before merging). The changes to font building at #2866 might also affect this PR. |
|
Any update on this? |
|
Yes please can someone please review this? |
9a985be to
0ef8921
Compare
Fixes #471 , adding support for the
\textsccommand via the small caps fontcmcsc10. Thanks to everyone who suggested solutions in the original thread. I'm willing to take this over the finish line, but will need a bit of assistance verifying that the changes I made are reasonable.For future reference, these are the steps I needed to take (inside the dev container) to run the font generation scripts on my machine:
sudo apt install mftrace fontforge fonttools ttfautohint texlive-fonts-recommended(should these be added to the dev container?)src/fonts/Makefileto call perl withperl -I .since@INCno longer includes the current working directory in recent Perl versionssudo apt-get install python-pippip install fonttools zopfli brotli./dockers/fonts/buildMetrics.shcd src/fonts && make clean && make allOutput for
\textsc{Lorem Ipsum Dolor}Questions / Concerns:
src/buildCommon.js). Not all combinations are valid, and I'm not sure what the desired priority is, so I made my best guess.src/fonts/makeFForsrc/fonts/makeBolder?\textit,\textsc,\mathbf, etc.) causes the text to render as small caps. Why might this be? How to fix it?src/fonts/makeFFandsrc/metrics/mapping.pl? Is one generated from the other? Should they be kept in sync somehow? The changes I made to each were just my best guess.docs/browser.mdwhich I suspect will need to be updated with the new font.