fix(fonts): update fonts dependencies by ylemkimon · Pull Request #2866 · KaTeX/KaTeX

ylemkimon · 2021-03-29T20:40:56Z

Update base image to Ubuntu 20.04
Use precompiled ttfautohint (1.8.3)
- Remove build-related tools: wget, man-db, pkg-config
Use Python 3
Update fonttools to 4.21.1

There are subpixel changes to the screenshots: diff.zip.

codecov-io · 2021-03-30T14:14:36Z

Codecov Report

Merging #2866 (45648ab) into master (fe21971) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2866   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          87       87           
  Lines        6326     6326           
  Branches     1308     1308           
=======================================
  Hits         5942     5942           
  Misses        354      354           
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe21971...45648ab. Read the comment docs.

ylemkimon · 2021-03-30T14:26:11Z

This PR is ready for review.

edemaine · 2021-05-18T15:15:49Z

@ylemkimon I'm happy to take a look at this now. Could you resolve the conflict / update the screenshots?

edemaine · 2021-07-21T14:52:30Z

@ylemkimon It would be nice to get font building working again. Do you have some time to look at this, or should I try to fix it myself?

codecov-commenter · 2021-07-29T19:19:21Z

Codecov Report

Merging #2866 (9cf4456) into master (6fa1adb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2866   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          88       88           
  Lines        6345     6345           
  Branches     1314     1314           
=======================================
  Hits         5961     5961           
  Misses        354      354           
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa1adb...9cf4456. Read the comment docs.

ylemkimon · 2021-07-29T19:29:44Z

@edemaine Sorry for the delay. This PR is ready for review.

edemaine

I finally reviewed this, testing on a Linux machine. Everything looks great, in particular generating the exact same font files, except for two commits which I added already. Could you review them and then merge? Here is what I changed:

The code did cd "$(dirname "$0")/../.." and then referred to the path $(dirname $0) again. This doesn't work when the path is relative (e.g. ./buildFonts.sh or even dockers/font/buildFonts.sh). I replaced the latter occurrences with dockers/fonts.
There was an uncalled function that claimed to deal with arguments, but no arguments seem to actually be supported. (We could support -h, but why bother if no arguments are supported. 🙂 )
buildMetrics.sh instructions had a typo (docker vs. dockers), and generalized the script to run from anywhere.

In either case, feel free to replace with more suitable code. Thanks for these improvements!

edemaine · 2021-08-28T17:22:18Z

It seems that buildFonts.sh doesn't run buildMetrics.sh. Do we not have a Dockerized buildMetrics.sh? It would be nice to include, perhaps in a future PR.

edemaine · 2021-08-28T17:45:17Z

Another question: Should we add scripts for build:fonts and build:metrics or something along those lines? Having them in the scripts list makes it more obvious that they exist.

ylemkimon · 2021-08-28T22:06:55Z

@edemaine Thank you very much!

## [0.13.14](v0.13.13...v0.13.14) (2021-08-28) ### Bug Fixes * **fonts:** update fonts dependencies ([#2866](#2866)) ([ea409ea](ea409ea))

KaTeX-bot · 2021-08-28T22:11:39Z

🎉 This PR is included in version 0.13.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

edemaine · 2021-08-28T22:15:48Z

Oops, maybe this should have been chore instead of fix, but not a big deal. 🙂 We'll have a bunch more releases with actual font-based features soon.

ylemkimon · 2021-08-28T22:31:03Z

@edemaine Since fonts are updated, a patch release makes sense.

fix(fonts): update fonts dependencies

c4f54ef

ylemkimon added the build fonts WARNING: this grants write access to the PR label Mar 29, 2021

github-actions bot removed the build fonts WARNING: this grants write access to the PR label Mar 29, 2021

ylemkimon added the build fonts WARNING: this grants write access to the PR label Mar 29, 2021

github-actions bot removed the build fonts WARNING: this grants write access to the PR label Mar 29, 2021

ylemkimon added 3 commits March 30, 2021 20:50

chore(fonts): fix buildMetrics for Python 3

d89e053

fix(fonts): update fonts

db45816

test: update screenshots

be64c32

ylemkimon force-pushed the update-fonts branch from 0ad2b04 to be64c32 Compare March 30, 2021 13:45

ylemkimon added 3 commits March 30, 2021 22:53

docs: update reference to katex-fonts

ac5d5ff

chore: use Python 3

87a4c4a

Merge remote-tracking branch 'origin/master' into update-fonts

8ea1585

ylemkimon added the build fonts WARNING: this grants write access to the PR label Mar 30, 2021

github-actions bot removed the build fonts WARNING: this grants write access to the PR label Mar 30, 2021

fix(fonts): update fonts

45648ab

ylemkimon added the build fonts WARNING: this grants write access to the PR label Mar 30, 2021

github-actions bot removed the build fonts WARNING: this grants write access to the PR label Mar 30, 2021

edemaine mentioned this pull request May 18, 2021

fix(fonts): capital Greek letters that look like Latin letters #3029

Open

benrbray mentioned this pull request Jul 6, 2021

feat: Support \textsc via small caps font cmcsc10 #3085

Open

6 tasks

Merge remote-tracking branch 'origin/master' into update-fonts

a9cbcf0

ylemkimon added the build fonts WARNING: this grants write access to the PR label Jul 29, 2021

github-actions bot removed the build fonts WARNING: this grants write access to the PR label Jul 29, 2021

test: update screenshots

c9d5605

Merge branch 'master' into update-fonts

f3ba612

edemaine added 2 commits August 28, 2021 12:30

Use explicit path

af95db2

Command-line arguments aren't actually supported

3ac9d76

edemaine approved these changes Aug 28, 2021

View reviewed changes

Comment thread src/fontMetricsData.js

edemaine mentioned this pull request Aug 28, 2021

fix(fonts): correct width of \cong glyph, fix \boldsymbol{\cong} #3206

Merged

Small buildMetrics fixes

e2689f4

ylemkimon added 3 commits August 29, 2021 06:35

Add build:{fonts,metrics} script

cd5b614

Lock versions of font-related dependencies

53aa252

Install minimal texlive

4296857

ylemkimon added the build fonts WARNING: this grants write access to the PR label Aug 28, 2021

github-actions bot removed the build fonts WARNING: this grants write access to the PR label Aug 28, 2021

Install fontforge

87ab0e3

ylemkimon added the build fonts WARNING: this grants write access to the PR label Aug 28, 2021

github-actions bot removed the build fonts WARNING: this grants write access to the PR label Aug 28, 2021

Merge branch 'master' into update-fonts

9cf4456

ylemkimon merged commit ea409ea into master Aug 28, 2021

ylemkimon deleted the update-fonts branch August 28, 2021 22:06

KaTeX-bot added a commit that referenced this pull request Aug 28, 2021

chore(release): 0.13.14 [ci skip]

f8c211d

## [0.13.14](v0.13.13...v0.13.14) (2021-08-28) ### Bug Fixes * **fonts:** update fonts dependencies ([#2866](#2866)) ([ea409ea](ea409ea))

KaTeX-bot added the released label Aug 28, 2021

This was referenced Sep 1, 2021

Wrong position of \in in subscript #3219

Closed

fix(fonts): remove hints from unknown symbols #3222

Merged

Uh oh!

Conversation

ylemkimon commented Mar 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ylemkimon commented Mar 30, 2021

Uh oh!

edemaine commented May 18, 2021

Uh oh!

edemaine commented Jul 21, 2021

Uh oh!

codecov-commenter commented Jul 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ylemkimon commented Jul 29, 2021

Uh oh!

edemaine left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

edemaine commented Aug 28, 2021

Uh oh!

edemaine commented Aug 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ylemkimon commented Aug 28, 2021

Uh oh!

KaTeX-bot commented Aug 28, 2021

Uh oh!

edemaine commented Aug 28, 2021

Uh oh!

ylemkimon commented Aug 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ylemkimon commented Mar 29, 2021 •

edited

Loading

codecov-io commented Mar 30, 2021 •

edited

Loading

codecov-commenter commented Jul 29, 2021 •

edited

Loading

edemaine left a comment •

edited

Loading

edemaine commented Aug 28, 2021 •

edited

Loading