Conversation
Move the mutable to HighlightedLine::m_layout and use a factory function to initialize it. Then follow the rule of zero and generally slightly cleanup this code here while at it.
Instead of using a signal connection here, call the function directly. This is slightly more efficient, but - more importantly - ensures we don't reconnect this signal multiple times, once every time we call HighlightedText::setText.
Collaborator
|
I'm going to pick a different approach |
Don't always append data, resize-to-fit and then transform. Sadly, QStringList has no resize, so we need to copy+for_each there instead. Fixes: #577
milianw
force-pushed
the
fix-sourcecode
branch
from
70863ec to
c6cc1a7
Compare
Contributor
|
At least with the new approach-the problem persists. I suggest to reopen the originating issue.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vectors containing the source code are not reset correctly. This results one some old code being shown. This patch resets them correctly.
fixes: #577