Merged
Conversation
Contributor
|
Is there any option to adjust the search model test for that case? |
milianw
requested changes
Jan 17, 2024
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
I would also appreciate a better test coverage to handle this ideally
Contributor
Author
|
I rewrote the search functions to use iterators instead + added some tests |
Contributor
|
Looking forward to get this merged. |
The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: #577
lievenhey
force-pushed
the
fix-search
branch
10 times, most recently
from
32067fe to
044d9f1
Compare
milianw
approved these changes
Apr 17, 2024
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
one minor nit then this can go in
thank you!
Contributor
|
I've pot some time into testing the appimage - the source handling in the Disassembly window now seems to work fine. The only thing that feels strange is the go to function:
And of course #523 and #528 as well as #607 would be very helpful. |
Until now search() works on an array like object. This works fine if the whole array is searched. But if only a part is searched, this creates an unnecessary copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code.
fixes: #577