fix multiline highlighting was ~add ci test for non optional build~#594
fix multiline highlighting was ~add ci test for non optional build~#594
Conversation
|
I encountered a similar problem when I tried debugging my changes. In that case it was impossible to build hotspot without |
|
Nice, the ci found the first bug already |
lievenhey
force-pushed
the
fix-highlighting
branch
5 times, most recently
from
c14b27f to
a3b2909
Compare
|
Multi line comments are now highlighted correctly |
|
dammit, it broke the disassembler |
lievenhey
force-pushed
the
fix-highlighting
branch
from
a3b2909 to
c76fd1c
Compare
|
now it is working correctly |
|
Nice work! the PR's title may should be adjusted, or the changes split into two PRs (I don't think that's necessary as long as it is split in the commits) |
lievenhey
changed the title
lievenhey
force-pushed
the
fix-highlighting
branch
3 times, most recently
from
f13a9e2 to
f5aef07
Compare
|
I split the ci change off into its own pr |
|
I do wonder if not resetting the highlighter has any performance impact |
|
It has. Until this patch the Highlighter was called on demand. Now it is called once for the whole file. |
lievenhey
force-pushed
the
fix-highlighting
branch
2 times, most recently
from
c76fd1c to
411d7b9
Compare
|
I guess that's good to go after solving the merge conflict. |
lievenhey
force-pushed
the
fix-highlighting
branch
from
411d7b9 to
df3e5bd
Compare
|
Just wondering: Is there anything blocking the pull here? |
|
Milians high workload. |
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
can you also add a test for this please? otherwise feel free to merge as-is for now already
If the state is reset every line KSyntaxHighlighter will be unable to highlight multi line comments (for example). This patch changes that by highlighting everyting at once.
lievenhey
force-pushed
the
fix-highlighting
branch
from
df3e5bd to
9f76aac
Compare
3 participants
This commit adds a ci build to build hotspot without optional dependencies. This should prevents bugs like #575 (fails to build without qcustomplot).