Add error message when exporting a flamegraph that hasn't been opened#588
Merged
Add error message when exporting a flamegraph that hasn't been opened#588
Conversation
milianw
requested changes
Jan 10, 2024
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
can you please instead disable the action and re-enable it when canConverToImageChanged (and thus add that signal too)
In order to save a flamegraph to an image or SVG, it must have been opened at least once so the graphics item is loaded. If you try to export it before doing so, you'll still get prompted to save the file, but it won't be (nor can be) written. Now there's an explicit check with it's own error message in that case.
lievenhey
force-pushed
the
wip/josh/fix-flamegraph-save
branch
from
57904da to
e8a6516
Compare
milianw
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to save a flamegraph to an image or SVG, it must have been opened at least once so the graphics item is loaded. If you try to export it before doing so, you'll still get prompted to save the file, but it won't be (nor can be) written.
Now there's an explicit check with it's own error message in that case.