added test for PERF_FORMAT_LOST attribute#579
Merged
milianw merged 3 commits intoKDAB:masterfrom Jan 13, 2024
Merged
Conversation
GitMensch
force-pushed
the
ZeroCostCrash
branch
from
9cff3a9 to
802d166
Compare
Collaborator
|
this looks conceptually broken to me, I rather believe that this goes wrong in perfparser land somehow - question is how and why. I have spend some time now and found the real issue in perfparser ab14b6989d123af60f4c822e8ece8638945139c6 - can you please rework this patch to only add the basic test coverage? that's fine, the rest shouldn't be needed |
Contributor
Author
|
KDAB/perfparser@ab14b69 looks nice. Yes, I'll add the testcase part, then push and re-request a review. |
GitMensch
force-pushed
the
ZeroCostCrash
branch
from
802d166 to
fd75a39
Compare
Contributor
Author
|
Test case reworded and checked in without the skipping, works fine. Note: the current output of the testcase is: I still think that there's some performance issue - which seems to only occur during |
GitMensch
changed the title
milianw
reviewed
Jan 2, 2024
GitMensch
force-pushed
the
ZeroCostCrash
branch
from
fd75a39 to
eb8a371
Compare
Contributor
Author
|
This PR now contains 3 commits: the test without the lookup-time comment (as solved by KDAB/perfparser#34), the minor adjustment to const the newSize in perfparser (not a huge improvement, but definitely more clear), and the unsetting of DEBUGINFOD_URLS as requested (along with removing comments about long parsing times that are gone as soon as KDAB/perfparser#34 is applied) I suggest to pull both this and the referenced perfparser changes in (+adjust the submodule reference), then have a look if it is possible to reduce the amount of calls to |
milianw
requested changes
Jan 3, 2024
reduce and drop the unneeded wait time parameter (for full speed on Debian/Ubuntu this additionally needs KDAB/perfparser#34 to be applied)
GitMensch
force-pushed
the
ZeroCostCrash
branch
from
eb8a371 to
fea12d6
Compare
Contributor
Author
|
adjusted as requested, should be ready to be merged (of course - please pull the hotspot-perfparser change first and update the reference, otherwise this will now fail on Debian/Ubuntu) |
milianw
approved these changes
Jan 13, 2024
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
thanks, I'll merge this and look at the perfparser change next. there's no direct dependency, worst case the test will fail now but it's fine on the CI and that's what counts for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #578
note: the testcase output now has:
further note: this testcase without the binary files needed 45-95 seconds.
I'm quite sure that this can be improved - but I don't have an environment where I can easily perf record that.