Skip to content

use python 3.11 to run pre-commit on the ci#547

Merged
lievenhey merged 1 commit intomasterfrom
fix-precommit
Oct 30, 2023
Merged

use python 3.11 to run pre-commit on the ci#547
lievenhey merged 1 commit intomasterfrom
fix-precommit

Conversation

@lievenhey
Copy link
Contributor

@lievenhey lievenhey commented Oct 30, 2023

the old pre-commit action broke and is no longer working I relpaced it with pre-commit-lite which support auto fixup

python got updated to 3.12 which broke pre-commit

@lievenhey lievenhey force-pushed the fix-precommit branch 4 times, most recently from f1a0dab to 232c46f Compare October 30, 2023 12:59
@lievenhey lievenhey changed the title port away from deprecated pre-commit action use python 3.11 to run pre-commit on the ci Oct 30, 2023
actions/setup-python seems to always use the newest python version by
default. This broke the ci since apparently pre-commit is not compatible
with python 3.12. Fixed by forcing it to run with python 3.11
Copy link
Collaborator

@milianw milianw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@lievenhey lievenhey merged commit 33dbc44 into master Oct 30, 2023
@lievenhey lievenhey deleted the fix-precommit branch October 30, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants