Merged
Conversation
GitMensch
force-pushed
the
patch-2
branch
2 times, most recently
from
8627b70 to
75a6cfa
Compare
GitMensch
changed the title
Contributor
|
@GitMensch lgtm, but can you ran |
Contributor
Author
|
applied |
milianw
requested changes
Oct 29, 2023
Contributor
Author
|
milianw
requested changes
Oct 29, 2023
invoke directly from the processPath already resolved before
fixing view part of KDAB#536
* comon formatting * always showing the problem details
Contributor
Author
|
rebased and split from 2 to 3 separate commits (I do like the result more than the original, too); tested manually in the GUI using the files under "tests" (all but the timeout, checked this with the appImage and also works as expected). Adjusted one test as needed and added some of the missing tests for the adjusted messages. |
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After recognizing that the process path of objdump is resolved first, I've adjusted the PR to use that (so the additional
statcalls seen in #527 are not needed).