Conversation
Contributor
Author
|
I have to check the output of the appimage build since the warning is only shown there |
milianw
requested changes
Oct 17, 2023
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
add a test for this case please
Contributor
Author
|
How do I test this? Since gcc 5 |
lievenhey
force-pushed
the
fix-search-undef
branch
2 times, most recently
from
47507d6 to
5672127
Compare
milianw
requested changes
Oct 19, 2023
start was set to current + 1 which will cause undefined behavior if current is the last element this patch adds a check for this and wraps around in that case fixes: #526
lievenhey
force-pushed
the
fix-search-undef
branch
from
5672127 to
cb1e6ac
Compare
milianw
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start was set to current + 1 which will cause undefined behavior if current is the last element
this patch adds a check for this and wraps around in that case
fixes: #526