shove flamegraph controls into QToolBar#512
Merged
Conversation
lievenhey
force-pushed
the
flamegraph-qtoolbar
branch
from
7e7b63c to
a362eda
Compare
milianw
requested changes
Sep 27, 2023
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
minor nit, otherwise lgtm - thanks
lievenhey
force-pushed
the
flamegraph-qtoolbar
branch
from
a362eda to
82453a5
Compare
milianw
force-pushed
the
flamegraph-qtoolbar
branch
from
82453a5 to
2f74641
Compare
This change removes the minimum width requirements of about 1100pixels for the hotspot mainwindow. The remaining window size constraints are defined by the tabs. When the window is small, the QToolBar will hide the actions and show a button to list them in a drop down menu. We also reorder the actions slightly and give the search box a minimum width, to make it more useable. fixes: #501
These back/forward actions can be embedded directly and get properly styled for us by KDE. There's no need to do anything of our own here.
This is available since KF5 5.23 and we depend on 5.42 already.
There's now enough space there and it fits well into the overall scope of this control in my opinion.
milianw
force-pushed
the
flamegraph-qtoolbar
branch
from
fedf699 to
d3f3b23
Compare
milianw
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the minimum width requirements of about 1100pixels, since Qt can hide widgets of a QToolBar in a menu.
fixes: #501