Adjust to KF6 KNotification API change#511
Conversation
setWidget has been removed in favor of setWindow.
|
This possibly relates to the removal of the original function https://invent.kde.org/frameworks/knotifications/-/merge_requests/123 - but QT6 builds error with
because that old PR https://invent.kde.org/frameworks/knotifications/-/merge_requests/16 was only merged recently (1 month ago) so this change is reasonable but the macro used is wrong (not sure if there's actually a usable one yet). |
|
@kbroulik ping? can you update the MR please? |
|
Update to do what? |
|
To fix the version check, see the failing test on our Qt6 CI which doesn't yet have this new API apparently: |
|
Then I suppose your neon is outdated. KF6 has no “version” yet, it’s all git master in-flux. I have been using hotspot like this for the past few days on my neon under Plasma 6 just fine. |
|
🤦♂️ thanks for clearing that up, now it's obvious that the error is on our side. I'll see when I get around to update the image and then merge this. Doing so now would break our CI - sorry. I should find the time for that on the weekend I hope. |
|
thanks @kbroulik - I updated our docker image for neon, and it works as expected now. Cheers! |
setWidget has been removed in favor of setWindow.