Merged
Conversation
lievenhey
force-pushed
the
set-source-path
branch
from
691b24a to
20c333c
Compare
milianw
previously requested changes
May 25, 2023
lievenhey
force-pushed
the
set-source-path
branch
2 times, most recently
from
7a9187e to
2ab5d53
Compare
milianw
requested changes
Jul 4, 2023
this patch add allows the user to add a custom source path which will overwrite the source path provided in the binary this makes the disassembler, ... work if the source code directory was moved after creating the binary closes: #418
lievenhey
force-pushed
the
set-source-path
branch
from
2ab5d53 to
5803fd6
Compare
milianw
approved these changes
Jul 4, 2023
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
lgtm, feel free to push once the CI has tested it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch add allows the user to add a custom source path which will
overwrite the source path provided in the binary
this makes the disassembler, ... work if the source code directory was
moved after creating the binary
closes: #418