fix sorting order of location in caller callee view#468
Merged
Conversation
Collaborator
|
huh? how does this fix it? you now only sort by the line which is totally bogus? instead, we should use a QCollator in the proxy model for sorting and enable numeric mode on that |
lievenhey
force-pushed
the
fix-sorting-order
branch
from
ab1a309 to
f8b036c
Compare
Contributor
Author
|
I didn't know that sorting by filename is required. In that case we can leverage |
lievenhey
force-pushed
the
fix-sorting-order
branch
from
f8b036c to
9520607
Compare
milianw
requested changes
Mar 3, 2023
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
please don't inline the code, as it leads to code bloat
milianw
reviewed
Mar 3, 2023
lievenhey
force-pushed
the
fix-sorting-order
branch
from
9520607 to
0223069
Compare
milianw
requested changes
Mar 10, 2023
lievenhey
force-pushed
the
fix-sorting-order
branch
from
0223069 to
760ba4b
Compare
milianw
requested changes
Mar 14, 2023
lievenhey
force-pushed
the
fix-sorting-order
branch
2 times, most recently
from
9ada156 to
c2e7728
Compare
Contributor
|
Rechecked: I can confirm that the resulting appimage fixe the original issue just fine, sorting first the filename (alphanumeric) then the line numbers (numeric). Thank you! |
milianw
requested changes
Apr 18, 2023
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
really minor nits, otherwise lgtm now
add a new sfpm for SourceMapModel that implements lessThen to correctly sort the locations fixes: #466
lievenhey
force-pushed
the
fix-sorting-order
branch
from
c2e7728 to
f95b0c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sort by line not by alphabetic string
fixes: #466