Make libdebugd check in perfparser.cmake take into account library status#465
Merged
milianw merged 1 commit intoKDAB:masterfrom Feb 10, 2023
Merged
Make libdebugd check in perfparser.cmake take into account library status#465milianw merged 1 commit intoKDAB:masterfrom
milianw merged 1 commit intoKDAB:masterfrom
Conversation
…atus There are cases where `HAVE_DWFL_GET_DEBUGINFOD_CLIENT` can be true while `LIBDEBUGINFOD_LIBRARIES` is marked as "NOT-FOUND". Add extra check to take this into account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my computer I have libdebugd disabled. However it seems like it still finds some symbols from it in
libdwfl.h. This would make the configure step fail asLIBDEBUGINFOD_LIBRARIESwould be set toNOT-FOUNDbut it would still try to use it.I'm guessing having the
HAVE_DWFL_GET_DEBUGINFOD_CLIENTis there to ensure that the whole pipeline has libdebugd support. However it also needs to check if the libraries are found as it is not certain that the libdebugd libraries are available even ifHAVE_DWFL_GET_DEBUGINFOD_CLIENTis true.