Merged
Conversation
GitMensch
force-pushed
the
perfdata
branch
5 times, most recently
from
e506636 to
e71072c
Compare
milianw
requested changes
Dec 3, 2022
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
please reword your commit message, it's pretty confusing. it would be better to clearly state that you are adding the *.perfdata pattern to the file open filter list
GitMensch
force-pushed
the
perfdata
branch
3 times, most recently
from
aee5993 to
da99dd0
Compare
milianw
requested changes
Dec 3, 2022
milianw
approved these changes
Dec 3, 2022
Collaborator
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
code lgtm, let's wait for the CI and then this can be merged
Collaborator
|
Argh sorry, it cannot be const b/c we need to pass |
milianw
requested changes
Dec 3, 2022
along with a group that includes the pattern and moving out to a separate function again
milianw
approved these changes
Dec 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
along with a group that includes it and moving out to a separate function again
fixing the side issue mentioned in #440