Skip to content

disable "Dissasembly" function for inlined functions (size calculation of inline functions not possible) #548

@GitMensch

Description

@GitMensch

Describe the bug
The size is definitely wrong (the inlined code consists of two 8 byte memcmp which are both done and a function call that is never executed). This leads to not usable disassembly view:
huge size seen by huge end address

To Reproduce
Steps to reproduce the behavior:

  1. Use a recording that has a lot of calls of an inlined function at several places within a huge function; including inlining at the calling functions start and end.
  2. Use disassembly feature
  3. wait for some time, then see timeout (before the changes fixing SIGSEGV on opening disassembly #542 actually a SIGSEGV)
  4. see (with adjustments to objdump call  #535 applied) a huge size calculated for the inlined function

Expected behavior
Open to discussion; the actual disassembly for inlined functions possibly could vary (I'm not sure), otherwise either disassemble the inlined version that has most cost (if we know that), otherwise the first one

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions