Repository navigation
perf(server): apply targeted field projections to auth, config, and holiday queries - #34
Merged
Merged
Conversation
…oliday queries Inspired by pingdotgg/t3code#13704, pingdotgg/t3code#10108, pingdotgg/t3code#10341. Project only required fields (authTokenHash, authTokenCreatedAt, settings, profile.startDate) to eliminate deserialization overhead and avoid transferring scrypt password hashes and large monthly signOff objects across queries.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Authentication checks (
requireAuth, SSE sync) and configuration lookups (getUserSettings,listHolidays) were executing unprojected Mongoose queries (User.findById().lean(),Config.findOne().lean()).Userdocument was retrieved and deserialized, including the scrypt password hash.Config.findOne()retrieved entire user profiles and potentially large monthlysignOffsrecords when onlysettingsorprofile.startDatewere required.Mechanism
Add targeted Mongoose field projections using
.select():server/middleware/require-auth.js:.select('authTokenHash authTokenCreatedAt')server/routes/sync.routes.js:.select('authTokenHash')server/services/entry.service.js:getUserSettingsqueriesConfig.findOne({ userId }).select('settings')server/services/holiday.service.js:listHolidaysqueriesConfig.findOne({ userId }).select('profile.startDate')server/middleware/require-auth.test.jswith.select()mock support and explicit projection verification test.Upstream Inspiration
Before / After Numbers
npm test: 125/125 tests passing (5-run median: 539.82 ms).npm run build: Vite build passes in ~1.90s.signOffsdictionary on entry updates.Risk
Very Low. Field projections match the exact fields read by callers. Verified by test suite.