Skip to content

Update tokenization_qwen2.py#3

Merged
JustinLin610 merged 1 commit into
JustinLin610:add_qwen2from
jklj077:patch-1
Jan 11, 2024
Merged

Update tokenization_qwen2.py#3
JustinLin610 merged 1 commit into
JustinLin610:add_qwen2from
jklj077:patch-1

Conversation

@jklj077

@jklj077 jklj077 commented Jan 11, 2024

Copy link
Copy Markdown

No description provided.

@JustinLin610
JustinLin610 merged commit 73695ff into JustinLin610:add_qwen2 Jan 11, 2024
@jklj077
jklj077 deleted the patch-1 branch January 13, 2024 11:37
JustinLin610 pushed a commit that referenced this pull request Mar 18, 2024
* inital commit

* update

* update conversion checkpoint

* update conversion script

* nits

* some fixes

* nits

* merge

* fix permute

* nits

* fix

* nits

* nits

* nits

* fix rope

* fix both rope

* nites

* style

* make sure flax works

* fix flax init code

* fix foward

* nits

* print flax generation out

* current code

* nits

* SIIIIIIIIIIIIIIIIIII

* update

* add new tokenizer

* correct fast tokenizer

* fix conversion

* more comments

* fix modeling and conversion

* nits and nits

* nits testing

* add some tokenization tests

* add some edge cases

* add slow tests and fix them

* fixup

* fix copies for modeling

* fix copies

* add 7B slow tests

* fix

* fix

* fix tests

* make tokenizer cis go green

* styling

* last tokenizer nits

* update jax tests

* fix flax for 7b

* add jit testing 🤗

* cleanups

* isolated nit, inv_freq for rotary_emb.inv_freq

* propagate to jax

* Apply suggestions from code review

Co-authored-by: Sanchit Gandhi <[email protected]>

* adjust test

* fix conversion script

* change name

* correct file names

* update conversion script

* Fix bos and eos token ids in the model configuration (#3)

* update modelling

* update conversion script

* add static cache for gemma

* fix sdpa generate

* fix batched

* multiple fixes

* fix FA2

* final fix

* Rename a few missing strings and filenames (#4)

* merge with upstream main

* fix copies

* fix copies

* fix fixup

* fix fixup

* fix

* fix

* final tests

* fix fx gemma tests

* fix fx bf16/fp16 tests

* update slow fx tests

* fx slow tests: one logits, one generation

* move jit test standalone

* Apply suggestions from code review

* nits

* tokenizer updates

* more tokenization updates: custom GemmaSentencepieceExtrator

* style

* Update src/transformers/cache_utils.py

* Update src/transformers/models/gemma/__init__.py

* Update tests/models/gemma/test_modeling_flax_gemma.py

* small nits

* style

* update tokenization test

* fix the rotary embedding

* with style

* fix slow tests

* WARNING this commit might be very important for precisions

* Update tests/models/gemma/test_modeling_flax_gemma.py

* Update src/transformers/models/gemma/configuration_gemma.py

Co-authored-by: Lysandre Debut <[email protected]>

* Update src/transformers/models/gemma/modeling_flax_gemma.py

Co-authored-by: Lysandre Debut <[email protected]>

* small nits here and there!

* forgotten nit

* remove on the fly computation of inv_freq

* revert previous change, let's be safe and for now re-compute freq cis to make sure it's in float

* Apply suggestions from code review

Co-authored-by: Pedro Cuenca <[email protected]>

* Update src/transformers/models/gemma/convert_gemma_weights_to_hf.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update src/transformers/models/gemma/convert_gemma_weights_to_hf.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_flax_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_tokenization_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_tokenization_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_tokenization_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_tokenization_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* nit conversion script link

* fix some tests

* add not doctest and pr doctest

* repo consistency

* fix last CIs 🚀

* update all readmes

---------

Co-authored-by: younesbelkada <[email protected]>
Co-authored-by: Sanchit Gandhi <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Younes Belkada <[email protected]>
Co-authored-by: sanchit-gandhi <[email protected]>
Co-authored-by: Lysandre Debut <[email protected]>
JustinLin610 pushed a commit that referenced this pull request Mar 18, 2024
* Cohere Model Release (#1)

Cohere Model Release

* Remove unnecessary files and code (#2)

Some cleanup

* Delete cohere-model directory (#3)

* Make Fix (#5)

* Pr fixes (#6)

* fixes for pr

* pr fixes for the format

* pr fixes for the format

* src/transformers/models/auto/tokenization_auto.py

* Tokenizer test (#8)

* tokenizer test

* format fix

* Adding Docs and other minor changes (#7)

* Add modeling tests (#9)

* Smol Fix (#11)

* tokenization tests are fixed

* format fixes

* fix pr doc tests

* fix pr doc tests

* fix pr doc tests

* fix pr style check

* small changes in cohere.md

* FIX: Address final comments for transformers integration (huggingface#13)

* fix modeling final nits and add proper test file

* for now leave empty tests

* add integration test

* push new test

* fix modeling cohere (huggingface#14)

* Update chat templates to use the new API (huggingface#15)

---------

Co-authored-by: ahmetustun <[email protected]>
Co-authored-by: Younes Belkada <[email protected]>
Co-authored-by: Matt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants