Skip to content

fix(web): adopt upstream Stop feedback and prevent repeat-click resumes - #781

Merged
JustYannicc merged 11 commits into
mainfrom
fix/741-stop-running-turn
Oct 17, 2026
Merged

JustYannicc merged 11 commits into
mainfrom
fix/741-stop-running-turn

Conversation

@JustYannicc

@JustYannicc JustYannicc commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Problem

Stop gives no immediate feedback, then the same target becomes Resume. Repeated clicks restart the turn with "Continue where you left off." Reproduced with Claude Opus 5.5 and GPT-6.1 Sol on cloud and a fixture-only local server.

Change

Adopts the Stop implementation from pingdotgg/t3code#20809 through e71c58b3fb, preserving Ravdeep Kainth's authorship, including the follow-up permission-loss guard. Stop disables immediately, keeps its target after stopping, and puts Resume beside it. A thread key resets pending state when switching threads. A Stop that lands after the retry timeout still keeps its old target.

The one Signalbox-only runtime delta is !sendLock?.locked on the landed-state branch, preserving our existing composer send lock. Regression cases live in ComposerPrimaryActions.signalbox.test.tsx on our current jsdom harness, including e71c58b3fb's removal of unnecessary module mocks. The upstream test file is byte-identical to main. The temporary fork suite is deleted once #20809 lands and the sync brings its browser tests.

Scope and approval

Fixes #741. Implements #779 item 5. Upstream report: pingdotgg/t3code#20404. The same-slot bug dates to de34391, before the latest upstream sync. Web and desktop share this component. Native mobile has a separate Stop-to-disabled-Send path and is unchanged.

Verification

  • On 54fd3cb, all 14 component tests pass across the restored upstream suite and the fork suite, including 20 repeated clicks after the old cooldown, deliberate Resume, new-run reset, retry timeout, late interruption, a temporary loss of operate permission, send-lock/unlock interaction, per-thread instance isolation and typing after Stop. The permission regression fails before 43b13cab8f and passes after.
  • Targeted lint and formatting pass. Existing ChatComposer lint warnings remain. Web typecheck passes. No repo-wide checks ran locally.
  • Earlier revision e101c52 passed real local Opus 5.5 and GPT-6.1 Sol tests: immediate pending feedback, 35 repeated clicks with zero Continue messages, and an enabled Stop after deliberate Resume.
  • Preview deploy for 2dade7d passes real Opus 5.5 and GPT-6.1 Sol turns. Disabled Stopping appeared in 17 ms and 2 ms respectively. Twenty Opus clicks and 35 Sol clicks at the original target sent no Continue messages. Deliberate Resume starts a new interruptible run.
  • Thread switching passes: while Opus Stop was disabled Stopping, switch to the running Sol thread. Sol Stop is enabled with no inherited pending state. Both test threads finish stopped.
  • git merge-tree on 54fd3cb against upstream/main 89b42bf reports 54 conflict paths, all also present on the original fork base 2b7a9b5. This update adds none. The upstream test file remains byte-identical to current Signalbox main. The typed-text regression makes 20 Submit calls before 68b31e4013 and zero after.
  • The permission-guard preview deploy at 2ed845c passed. The normal Stop and thread-switch preview pass was on 2dade7d; the guard only changes behavior while operate permission is absent. Targeted lint, formatting and web typecheck pass on 54fd3cb. CI for this push is not yet verified.

Earlier local evidence: before, after, video. Draft release assets are visible to repository writers. Current preview running screenshot, stopped screenshot, and 49-second Opus/Sol video.

Model and harness: GPT-6.1 Sol via Codex in T3 Code; adopted commits by Ravdeep Kainth.

@JustYannicc

JustYannicc commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner Author

Local candidate e101c52 is verified on both providers. Claude Opus 5.5 showed disabled Stopping in 72 ms; GPT-6.1 Sol in 31 ms. In each case 35 repeated clicks at the original Stop coordinates sent zero new Continue messages. Deliberate Resume starts another turn and Stop is immediately enabled. The provider interrupt succeeded (Claude adapter span 1287 ms). The isolated dev server is stopped.

Local recording, before screenshot, after screenshot. These are uploaded in the draft PR evidence release, visible to repository writers.

Cloud preview and CI are still queued on GitHub; the #781 preview does not resolve yet. No candidate cloud success claim yet.

voida6 and others added 6 commits October 17, 2026 11:47
Stop could take seconds to land with no visible change, and once the run stopped the same slot became Resume, so repeat clicks sent "Continue where you left off". Stop now dims and ignores clicks until the run stops (re-enabling after 10 s if it never does), and Resume ignores clicks for 1 s after a stop lands.

Fixes #20404

(cherry picked from commit 32b15c5c150c5c3b1dbca5a0fa87890d042c953e)
Stopping is tracked as pending, then landed once the run stops. If the
thread becomes interruptible again after that, a new run has started, so
its Stop button is enabled immediately instead of waiting out the 10 s
pending window.

(cherry picked from commit 677991191ad6ccb7a1e50de3277d1e773339b63a)
Repeat clicks after a stop lands do not resume, a new run after a landed
stop gets a working Stop button, and Stop re-enables when the stop never
lands.

(cherry picked from commit b8a4ef698ea793504692be43358b22b7db51f6c8)
The one-second Resume guard still resumed the run when repeat Stop clicks
outlasted it. Keep the stopped button disabled in its slot and show Resume
beside it, so no amount of clicking on the old target resumes.

Key the footer actions by thread so a pending stop does not carry over to
another thread, since the composer stays mounted across threads.

Co-authored-by: Yannic Charlon <[email protected]>
(cherry picked from commit cd049fc667d66d334e3a064a3cbc017a589ebb51)
A stop that landed after the 10 s fallback reset the slot to a plain
Resume button, so repeat Stop clicks could resume the thread. The timeout
now moves to a timed-out phase that keeps Stop retryable and still
transitions to landed when the run stops.

(cherry picked from commit 60d547a6652ca22321c64a0bf13ed521c0445b31)
canInterrupt includes the operate permission, so a permission flap during
a run looked like the stop had landed. Stop transitions now wait until the
permission holds again.

(cherry picked from commit 43b13cab8f4a79b8a66f45c49338cef0ebac935a)
Backport the Stop suite from dea26966c38ac1d7005174959355d8890abafa9f. Signalbox has not adopted upstream browser-test infrastructure yet, so retain its current jsdom harness. Test bodies and cases match upstream.
@JustYannicc
JustYannicc force-pushed the fix/741-stop-running-turn branch from 5e687f7 to fba8b30 Compare October 17, 2026 10:21
@JustYannicc

JustYannicc commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner Author

#781 is at 4ab9566, carrying upstream #20809's Stop implementation through 68b31e4013 with authorship preserved. The only fork runtime delta is its send-lock guard. The upstream test file is now byte-identical to main; temporary regression coverage lives in ComposerPrimaryActions.signalbox.test.tsx until the upstream browser tests arrive in a sync.

All 14 component tests pass, including 20 repeat clicks, late timeout, permission loss, send-lock/unlock interaction, per-thread instance isolation and typing after Stop. Targeted lint/formatting and web typecheck pass. The local merge-tree check adds no conflicts against pinned upstream/main 89b42bf relative to main 2b7a9b5. Also adopted upstream's latest typed-text fix: its regression sends 20 messages before the fix and zero after.

Real preview proof remains linked on #781: Opus 5.5 and GPT-6.1 Sol show immediate disabled Stopping, repeat clicks send no Continue messages, deliberate Resume works, and switching from pending Opus Stop to running Sol leaves Sol Stop enabled. The 49-second video and screenshots are uploaded. Both test threads are stopped; all local processes and browser tabs are closed.

CI is rerunning on the latest commit, watched by the coordinator. Nothing merged.

The landed layout only held while Resume showed. Typing text after a stop
turned the old Stop slot into Submit, so repeat clicks could send. The
stopped button now stays beside Resume or Submit, compact toggle included.

(cherry picked from commit 68b31e4013070090e9083cd5da44d027e1e1f8d1)
The useSettings and SidebarStageBackdrop mocks leaked into
OpenInPicker.browser.test.tsx when both files ran in the browser project,
failing its revocation test. The Stop tests do not need them.

Backport the mock removal to ComposerPrimaryActions.signalbox.test.tsx.
Signalbox retains its jsdom harness until the upstream browser-test sync.

(cherry picked from commit e71c58b3fb70ce1d3aa93fba01d48931ed97af8b)
@JustYannicc
JustYannicc merged commit 11a71de into main Oct 17, 2026
25 checks passed
@JustYannicc
JustYannicc deleted the fix/741-stop-running-turn branch October 17, 2026 11:33
@JustYannicc

Copy link
Copy Markdown
Owner Author

Merged by the coordinator. CI is green on 54fd3cb (Upstream Merge included), with no bot findings.

  • Adopts upstream fix(web): Stop shows a pending state and repeat clicks no longer resume pingdotgg/t3code#20809 (Stop shows a pending state and repeat clicks no longer resume), carrying its commits with their authorship.
  • The only fork delta is the !sendLock?.locked guard.
  • The regression tests are in a fork-only file and get deleted once #20809 lands upstream and syncs in. Upstream's test file is untouched.
  • Preview proof: real Opus 5.5 and GPT-6.1 Sol turns stop; 20 and 35 same-spot clicks send no Continue; deliberate Resume works; a pending stop doesn't carry over when switching threads.
    A follow-up thread keeps pulling #20809's new commits in until it merges upstream.

🤖 Generated with Claude Code

This branch was previously deployed

1 inactive deployment
cloud-preview — 54fd3cb6 Deployed Oct 17, 2026 by JustYannicc via Delete preview cloud #907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop no longer stops a running turn (regression from the latest T3 Code release)

2 participants