Skip to content

Remove type inference profiling, since thread safety was never merged upstream.#25

Merged
NHDaly merged 2 commits intomainfrom
nhd-revert-inference-profiling
Aug 14, 2023
Merged

Remove type inference profiling, since thread safety was never merged upstream.#25
NHDaly merged 2 commits intomainfrom
nhd-revert-inference-profiling

Conversation

@NHDaly
Copy link
Copy Markdown
Member

@NHDaly NHDaly commented Aug 14, 2023

JuliaLang/julia#47615 was never merged, so this feature cannot be used yet anyway. :(

And the compat bounds are currently too strict, and are causing issues in RelationalAI's build

@NHDaly NHDaly force-pushed the nhd-revert-inference-profiling branch from 88001ec to 4183ac5 Compare August 14, 2023 16:31
… upstream:

JuliaLang/julia#47615 was never merged, so this
feature cannot be used yet anyway. :(

And the compat bounds are currently too strict, and are causing issues
in RelationalAI's build
@NHDaly NHDaly force-pushed the nhd-revert-inference-profiling branch from 4183ac5 to a0651fb Compare August 14, 2023 16:32
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #25 (a0651fb) into main (e38ab79) will increase coverage by 39.61%.
The diff coverage is n/a.

❗ Current head a0651fb differs from pull request most recent head 45e4afc. Consider uploading reports for the commit 45e4afc to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             main       #25       +/-   ##
============================================
+ Coverage   60.38%   100.00%   +39.61%     
============================================
  Files           1         1               
  Lines         154       133       -21     
============================================
+ Hits           93       133       +40     
+ Misses         61         0       -61     
Files Changed Coverage Δ
src/ProfileEndpoints.jl 100.00% <ø> (+39.61%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NHDaly NHDaly enabled auto-merge (squash) August 14, 2023 16:41
@NHDaly NHDaly merged commit 7b618bc into main Aug 14, 2023
@NHDaly NHDaly deleted the nhd-revert-inference-profiling branch August 14, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants