Fix EMNIST download URL and docstring#247
Merged
Merged
Conversation
The EMNIST dataset has a different download URL, which is now updated. Update the docstring to reflect actual EMNIST content.
Contributor
Author
|
Oh, there are a huge number of JuliaFormatter changes (yes, it's ~/.julia/dev/MLDatasets/ [emnist-source*] git diff --name-only | cat
docs/make.jl
src/MLDatasets.jl
src/containers/filedataset.jl
src/containers/hdf5dataset.jl
src/datasets/graphs/AQSOL.jl
src/datasets/graphs/chickenpox.jl
src/datasets/graphs/citeseer.jl
src/datasets/graphs/cora.jl
src/datasets/graphs/karateclub.jl
src/datasets/graphs/metrla.jl
src/datasets/graphs/movielens.jl
src/datasets/graphs/ogbdataset.jl
src/datasets/graphs/organicmaterialsdb.jl
src/datasets/graphs/pemsbay.jl
src/datasets/graphs/planetoid.jl
src/datasets/graphs/polblogs.jl
src/datasets/graphs/pubmed.jl
src/datasets/graphs/reddit.jl
src/datasets/graphs/temporalbrains.jl
src/datasets/graphs/traffic.jl
src/datasets/graphs/tudataset.jl
src/datasets/graphs/windmillenergy.jl
src/datasets/meshes/faust.jl
src/datasets/misc/iris.jl
src/datasets/misc/mutagenesis.jl
src/datasets/text/ptblm.jl
src/datasets/text/smsspamcollection.jl
src/datasets/text/udenglish.jl
src/datasets/vision/cifar10.jl
src/datasets/vision/cifar100.jl
src/datasets/vision/emnist.jl
src/datasets/vision/fashion_mnist.jl
src/datasets/vision/mnist.jl
src/datasets/vision/mnist_reader/readimages.jl
src/datasets/vision/omniglot.jl
src/datasets/vision/svhn2.jl
src/graph.jl
test/containers/filedataset.jl
test/containers/hdf5dataset.jl
test/containers/jld2dataset.jl
test/containers/tabledataset.jl
test/datasets/graphs.jl
test/datasets/graphs_no_ci.jl
test/datasets/misc.jl
test/datasets/text.jl
test/datasets/text_no_ci.jl
test/datasets/vision/cifar10.jl
test/datasets/vision/cifar100.jl
test/datasets/vision/emnist.jl
test/datasets/vision/fashion_mnist.jl
test/datasets/vision/mnist.jl
test/datasets/vision/omniglot.jl
test/datasets/vision/svhn2.jl
test/runtests.jl
test/test_utils.jlPlease advise! Thanks. |
Collaborator
|
Thanks for the PR 🤗, works perfectly. I think the format tests are failing on main, so you don't need worry about it in the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EMNIST dataset now has a different download URL, which is now updated.
Update the docstring to reflect actual EMNIST content (the docstring was maybe from the MNIST?).
The tests do not seem to pass cleanly on my machine, but the EMNIST.jl tests do, so failures don't seem related to this patch.
Closes #227