Skip to content

lowering: don't reverse handler order in (pop-handler-list ...)#55871

Merged
vtjnash merged 1 commit intoJuliaLang:masterfrom
topolarity:ct/fix-pop-handler
Nov 18, 2024
Merged

lowering: don't reverse handler order in (pop-handler-list ...)#55871
vtjnash merged 1 commit intoJuliaLang:masterfrom
topolarity:ct/fix-pop-handler

Conversation

@topolarity
Copy link
Copy Markdown
Member

We were accidentally emitting a different pop order for Expr(:leave, ...) if you uncomment the nothing below:

let src = Meta.@lower let
    try
        try
            return 1
        catch
        end
    finally
        # nothing # <- uncomment me
    end
end
    println.(filter(stmt->Base.isexpr(stmt, :leave), src.args[1].code))
    nothing
end

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants