Skip to content

Devdocs on fixing precompile hangs, take 2#51895

Merged
timholy merged 9 commits intomasterfrom
jb/teh/devdocs_pchangs
Nov 13, 2023
Merged

Devdocs on fixing precompile hangs, take 2#51895
timholy merged 9 commits intomasterfrom
jb/teh/devdocs_pchangs

Conversation

@JeffBezanson
Copy link
Copy Markdown
Member

This is #50914, with only the documentation changes, plus an improvement to the warning message.

@brenhinkeller brenhinkeller added docs This change adds or pertains to documentation compiler:precompilation Precompilation of modules labels Oct 27, 2023
@timholy
Copy link
Copy Markdown
Member

timholy commented Oct 30, 2023

This should be updated to recommend the Aqua test, now that JuliaTesting/Aqua.jl#174 has merged. Though one issue is that Aqua v0.8 has not yet been released. Do you want to edit it or should I?

@JeffBezanson
Copy link
Copy Markdown
Member Author

Ok, please go ahead.

@JeffBezanson JeffBezanson added the backport 1.10 Change should be backported to the 1.10 release label Nov 2, 2023
@JeffBezanson JeffBezanson added this to the 1.10 milestone Nov 2, 2023
@timholy timholy force-pushed the jb/teh/devdocs_pchangs branch from 9cf7464 to bd36e1d Compare November 4, 2023 08:30
@timholy
Copy link
Copy Markdown
Member

timholy commented Nov 4, 2023

Done. I approve merging, but feel free to check the (slightly modified) description first.

@KristofferC KristofferC mentioned this pull request Nov 6, 2023
39 tasks
@IanButterworth
Copy link
Copy Markdown
Member

One build job failed 3 times so trying an update

@IanButterworth
Copy link
Copy Markdown
Member

Linux x86 musl is consistently failing here. I'm trying another update

@IanButterworth
Copy link
Copy Markdown
Member

The issues remain on musl which I've not seen elsewhere.
Either

LLVM ERROR: out of memory
Allocation failed
[10578] signal 6 (-6): Aborted

or

terminate called after throwing an instance of 'std::bad_alloc'
what():  std::bad_alloc
terminate called recursively
[10578] signal 6 (-6): Aborted

@timholy timholy merged commit 6d5787a into master Nov 13, 2023
@timholy timholy deleted the jb/teh/devdocs_pchangs branch November 13, 2023 16:32
KristofferC pushed a commit that referenced this pull request Nov 27, 2023
This is #50914, with only the documentation changes, plus an improvement
to the warning message.

---------

Co-authored-by: Tim Holy <[email protected]>
Co-authored-by: Ian Butterworth <[email protected]>
(cherry picked from commit 6d5787a)
KristofferC added a commit that referenced this pull request Dec 2, 2023
Backported PRs:
- [x] #51213 <!-- Wait for other threads to finish compiling before
exiting -->
- [x] #51520 <!-- Make allocopt respect the GC verifier rules with non
usual address spaces -->
- [x] #51598 <!-- Use a simple error when reporting sysimg load
failures. -->
- [x] #51757 <!-- fix parallel peakflop usage -->
- [x] #51781 <!-- Don't make pkgimages global editable -->
- [x] #51848 <!-- allow finalizers to take any locks and yield during
exit -->
- [x] #51847 <!-- add missing wait during Timer and AsyncCondition close
-->
- [x] #50824 <!-- Add some aliasing warnings to docstrings for mutating
functions in Base -->
- [x] #51885 <!-- remove chmodding the pkgimages -->
- [x] #50207 <!-- [devdocs] Improve documentation about building
external forks of LLVM -->
- [x] #51967 <!-- further fix to the new promoting method for
AbstractDateTime subtraction -->
- [x] #51980 <!-- macroexpand: handle const/atomic struct fields
correctly -->
- [x] #51995 <!-- [Artifacts] Pass artifacts dictionary to
`ensure_artifact_installed` dispatch -->
- [x] #52098 <!-- Fix errors in `sort` docstring -->
- [x] #52136 <!-- Bump JuliaSyntax to 0.4.7 -->
- [x] #52140 <!-- Make c func `abspath` consistent on Windows. Fix
tracking path conversion. -->
- [x] #52009 <!-- fix completion that resulted in startpos of 0 for `\\
-->
- [x] #52192 <!-- cap the number of GC threads to number of cpu cores
-->
- [x] #52206 <!-- Make have_fma consistent between interpreter and
compiled -->
- [x] #52027 <!-- fix Unicode.julia_chartransform for Julia 1.10 -->
- [x] #52217 <!-- More helpful error message for empty `cpu_target` in
`Base.julia_cmd` -->
- [x] #51371 <!-- Memoize `cwstring` when used for env lookup /
modification on Windows -->
- [x] #52214 <!-- Turn Method Overwritten Error into a PrecompileError
-- turning off caching -->
- [x] #51895 <!-- Devdocs on fixing precompile hangs, take 2 -->
- [x] #51596 <!-- Reland "Don't mark nonlocal symbols as hidden"" -->
- [x] #51834 <!-- [REPLCompletions] allow symbol completions within
incomplete macrocall expression -->
- [x] #52010 <!-- Revert "Support sorting iterators (#46104)" -->
- [x] #51430 <!-- add support for async backtraces of Tasks on any
thread -->
- [x] #51471 <!-- Fix segfault if root task is NULL -->
- [x] #52194 <!-- Fix multiversioning issues caused by the parallel llvm
work -->
- [x] #51035 <!-- refactor GC scanning code to reflect jl_binding_t are
now first class -->
- [x] #52030 <!-- Bump Statistics -->
- [x] #52189 <!-- codegen: ensure i1 bool is widened to i8 before
storing -->
- [x] #52228 <!-- Widen diagonal var during `Type` unwrapping in
`instanceof_tfunc` -->
- [x] #52182 <!-- jitlayers: replace sharedbytes intern pool with one
that respects alignment -->

Contains multiple commits, manual intervention needed:
- [ ] #51092 <!-- inference: fix bad effects for recursion -->

Non-merged PRs with backport label:
- [ ] #52196 <!-- Fix creating custom log level macros -->
- [ ] #52170 <!-- fix invalidations related to `ismutable` -->
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Dec 2, 2023
@KristofferC KristofferC mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler:precompilation Precompilation of modules docs This change adds or pertains to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants