add the package name to the LOAD_Pkgimage zone#49538
Merged
KristofferC merged 1 commit intomasterfrom Apr 28, 2023
Merged
Conversation
topolarity
reviewed
Apr 27, 2023
Member
topolarity
left a comment
topolarity
left a comment
There was a problem hiding this comment.
Timing looks good - this is great metadata.
I'm not the right person to review the ABI change, so I'll leave Approval for someone else to take a look
vchuravy
approved these changes
Apr 27, 2023
fatteneder
added a commit
to fatteneder/PkgCacheInspector.jl
that referenced
this pull request
May 12, 2024
- JuliaLang/julia#52123: Added the `int ignore_native` argument to jl_restore_package_image_from_file - JuliaLang/julia#49538: Added the `const char *pkgname` argument to jl_restore_package_image_from_file and jl_restore_incremental.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't figure out how to get the package name from within the function itself so I just passed it in from code loading instead.
It's nice to be able to see a list with the package names: