fix and test sorting arrays with >1 dimension and custom similar#49392
Merged
LilithHafner merged 3 commits intomasterfrom May 31, 2023
Merged
fix and test sorting arrays with >1 dimension and custom similar#49392LilithHafner merged 3 commits intomasterfrom
similar#49392LilithHafner merged 3 commits intomasterfrom
Conversation
LilithHafner
added
bugfix
51 tasks
Member
Author
|
I'm going to merge this bugfix in a couple days unless someone objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug only comes up when sorting
AbstractArraysthat are neitherAbstractVectorsnorArraysand define asimilar(A, dim::Int)that does not return aVector. It was introduced in 1.9, almost certainly my fault.