Abbreviate varinfo signature and re-order for consistency#48860
Merged
LilithHafner merged 2 commits intomasterfrom May 27, 2023
Merged
Abbreviate varinfo signature and re-order for consistency#48860LilithHafner merged 2 commits intomasterfrom
LilithHafner merged 2 commits intomasterfrom
Conversation
The signature line is very long, so I dropped the ::Bool annotations which imo don't add value. I also switched from mixed `m=Main` and `imported = false` style to consistent `m=Main` and `imported=false`. Consistent within a single line is better than inconsistent, and I chose more concise because we're well over the line limit. Also reorder the function arguments to match the docstring. NFC, but might avoid some confusion for IDEs that show the actual signature. cc @udohjeremiah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature line is very long, so I dropped the ::Bool annotations which imo don't add value. I also switched from mixed
m=Mainandimported = falsestyle to consistentm=Mainandimported=false. Consistent within a single line is better than inconsistent, and I chose more concise because we're well over the line limit.Also reorder the function arguments to match the docstring. NFC, but might avoid some confusion for IDEs that show the actual signature.
cc @udohjeremiah