Conversation
KristofferC
reviewed
May 9, 2022
KristofferC
approved these changes
May 9, 2022
vtjnash
requested changes
May 9, 2022
Member
vtjnash
left a comment
There was a problem hiding this comment.
Member
|
Note that even this support might be quite recent, since people were writing blogs about it not working within the past few years: https://weibeld.net/terminals-and-shells/italics.html |
14d5ab7 to
fdee440
Compare
Member
Author
|
Rebased. I included a note about terminal support in the docstring. |
vtjnash
approved these changes
Feb 13, 2023
Member
|
It's worth noting (and I think short of the docs a comment here has a chance of being seen at least) that italic support can be checked for in terminfo, and so the best practice would be adapting the printing behavior based on the terminal capabilities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.