Carry an openblas patch to fix bug in power kernels#21091
Merged
staticfloat merged 2 commits intomasterfrom Mar 19, 2017
Merged
Carry an openblas patch to fix bug in power kernels#21091staticfloat merged 2 commits intomasterfrom
staticfloat merged 2 commits intomasterfrom
Conversation
This reverts commit 145eae8. This was actually a bug in the power kernels in OpenBLAS, not a GCC or SuiteSparse problem
tkelman
added
backport pending 0.5
bugfix
Contributor
Author
|
Someone with access to a power system should verify that tests pass on this branch after a |
Member
|
@jlbuild !filter=ppc !nuke |
staticfloat
approved these changes
Mar 19, 2017
tkelman
added a commit
that referenced
this pull request
May 2, 2017
from OpenMathLib/OpenBLAS#1098 (cherry picked from commit 26beab3) ref #21091
tkelman
added a commit
that referenced
this pull request
May 3, 2017
from OpenMathLib/OpenBLAS#1098 (cherry picked from commit 26beab3) ref #21091 fix Makefile.system dependency for release-0.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #20165 because this was a bug in openblas, not gcc or suitesparse. X-ref #20123 (comment), I bisected on this in openblas (with a cross-compile using qemu, hopefully that shouldn't make a difference though) and identified OpenMathLib/OpenBLAS#1098 as fixing the problem. It's power-specific and applies cleanly to 0.2.19, so let's swap patches, carry the openblas power kernel fixes until there's a new release available.