Fragment arguments editorial#2
Merged
JoviDeCroock merged 12 commits intoJoviDeCroock:fragment-args-2024-amendmentsfrom Nov 28, 2025
Merged
Fragment arguments editorial#2JoviDeCroock merged 12 commits intoJoviDeCroock:fragment-args-2024-amendmentsfrom
JoviDeCroock merged 12 commits intoJoviDeCroock:fragment-args-2024-amendmentsfrom
Conversation
JoviDeCroock
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've reviewed sections 2 and 5 and applied various editorial changes to fix issues, make it consistent with the behavior of the implementation in graphql@alpha, make it more consistent with the terminology of the spec, add some additional examples, use definitions for terms, etc.
One key change is that we don't evaluate the variable's value to determine two variables are equivalent, instead we simply require that they come from the same definition.
I've also re-worked some algorithms that were trying to cover arguments and variables with the same code to instead split the handling of that code. Where algorithms do handle both, I've renamed some variables to make this clearer.
I've also tried to consistently use "fragment variables" for the variable definitions, and "fragment arguments" for the arguments passed to the spread; previously these were used a little more interchangeably. I've also used "named fragment spread" rather than just "fragment spread" in many places to make it clearer this only applies to named fragments (not inline spreads).